From owner-cvs-all Sat Mar 18 11: 0:30 2000 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 4C43237B58F; Sat, 18 Mar 2000 11:00:24 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id MAA10506; Sat, 18 Mar 2000 12:00:24 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id MAA97173; Sat, 18 Mar 2000 12:00:20 -0700 (MST) Message-Id: <200003181900.MAA97173@harmony.village.org> To: Joerg Wunsch Subject: Re: cvs commit: src/sys/isa fd.c fdc.h Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sat, 18 Mar 2000 10:27:02 PST." <200003181827.KAA70328@freefall.freebsd.org> References: <200003181827.KAA70328@freefall.freebsd.org> Date: Sat, 18 Mar 2000 12:00:20 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200003181827.KAA70328@freefall.freebsd.org> Joerg Wunsch writes: : Make the Y-E Data PCMCIA floppy of the Toshiba Libretto work under : -current. And there was much rejoicing :-). Thank you for your efforts in this area. I very much appreciate them. It is good to see more people contributing pccard code. It is likely a good MFC candidate for the newly created 4.0 branch (but after Jordan does the cdrom thing, since this change appears on its surface to be large). :... excellent commit message, btw : WARNING: "fd" is usurping "fd"'s cdevsw[] : WARNING: "fd" is usurping "fd"'s bmaj : : I suspect this is related to the XXX comment at the call to : cdevsw_add(). Does anybody know what the correct way is to cleanup : this? The way that the ad driver does this is to use disk_create. Its use of disk_destroy causes crashes for me, so I've #if 0'd them out on my local machines. You might want to look there. disk_create does the cdevsw_add if necessary, but only if necessary. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message