From owner-cvs-all Sun Feb 27 8:38:59 2000 Delivered-To: cvs-all@freebsd.org Received: from anchor-post-32.mail.demon.net (anchor-post-32.mail.demon.net [194.217.242.90]) by hub.freebsd.org (Postfix) with ESMTP id F0A4337B65C; Sun, 27 Feb 2000 08:38:41 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from nlsys.demon.co.uk ([158.152.125.33] helo=herring.nlsystems.com) by anchor-post-32.mail.demon.net with esmtp (Exim 2.12 #1) id 12P6iO-000O6L-0W; Sun, 27 Feb 2000 16:38:40 +0000 Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id QAA46405; Sun, 27 Feb 2000 16:42:21 GMT (envelope-from dfr@nlsystems.com) Date: Sun, 27 Feb 2000 16:41:28 +0000 (GMT) From: Doug Rabson To: Soren Schmidt Cc: Sren Schmidt , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c In-Reply-To: <200002271613.RAA43235@freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, 27 Feb 2000, Soren Schmidt wrote: > It seems Doug Rabson wrote: > > On Sun, 27 Feb 2000, Sren Schmidt wrote: > > > > > sos 2000/02/27 04:41:08 PST > > > > > > Modified files: > > > sys/dev/ata ata-all.c > > > Log: > > > Fix the problem that caused the boot to fail when modules were loaded. > > > > > > Real braino, confuses two different softc types, I wonder how this > > > could ever work :( > > > > Actually, it was confusing two devclasses and ended up with ata_devclass > > pointing at "atapci". This meant that lookups using ata_devclass returned > > devices like atapci0 instead of ata0 and things went downhill fast... > > That was what I meant but unclearly formulated. I still wonder how > this could work :| I think that we were unlucky in that when no modules were loaded, the various registrations happened a different order which left ata_devclass pointing at the right value. Loading modules can re-order the registration slightly as new SYSINITs are sorted into the list. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message