From owner-svn-src-head@freebsd.org Tue Sep 3 14:07:37 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4BCA6DD704; Tue, 3 Sep 2019 14:07:14 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N80K2zbBz4QNC; Tue, 3 Sep 2019 14:07:13 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id A7EEE1B2C0; Tue, 3 Sep 2019 14:06:32 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 6BFDC103C5; Sat, 20 Apr 2019 19:16:05 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26AF16E7FB; Sat, 20 Apr 2019 19:16:05 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 13D3C103C4; Sat, 20 Apr 2019 19:16:05 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 1B09B103BF for ; Sat, 20 Apr 2019 19:16:02 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6694D6E7F7; Sat, 20 Apr 2019 19:16:01 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x3KJFxjD023900; Sat, 20 Apr 2019 12:15:59 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x3KJFxp3023899; Sat, 20 Apr 2019 12:15:59 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201904201915.x3KJFxp3023899@gndrsh.dnsmgr.net> Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf In-Reply-To: <201904201859.x3KIxd9J023812@gndrsh.dnsmgr.net> To: rgrimes@freebsd.org CC: Warner Losh , Alan Somers , Justin Hibbits , src-committers , svn-src-all , svn-src-head Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 26AF16E7FB X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.91 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.91)[-0.913,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:37 -0000 X-Original-Date: Sat, 20 Apr 2019 12:15:59 -0700 (PDT) X-List-Received-Date: Tue, 03 Sep 2019 14:07:37 -0000 > > On Sat, Apr 20, 2019, 7:47 AM Alan Somers wrote: > > > > > On Sat, Apr 20, 2019 at 7:23 AM Justin Hibbits > > > wrote: > > > > > > > > > > > > > > > > On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: > > > >> > > > >> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits > > > wrote: > > > >> > > > > >> > > > > >> > > > > >> > On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > > > >> >> > > > >> >> Author: asomers > > > >> >> Date: Sat Apr 20 12:51:05 2019 > > > >> >> New Revision: 346441 > > > >> >> URL: https://svnweb.freebsd.org/changeset/base/346441 > > > >> >> > > > >> >> Log: > > > >> >> Use symlinks for kernel modules rather than hardlinks > > > >> >> > > > >> >> When aliasing a kernel module to a different name (ie if_igb for > > > if_em), > > > >> >> it's better to use symlinks than hard links. kldxref will omit > > > entries for > > > >> >> the links, ensuring that the loaded module has the correct name. > > > >> >> > > > >> >> > > > >> > > > > >> > > > > >> > Thanks! This should fix installkernel on my POWER9. > > > >> > > > > >> > - Justin > > > >> > > > >> What's the problem with your POWER9? Is that one of those msdosfs > > > >> /boot systems? If so, I don't think this will fix it. msdosfs > > > >> doesn't support either symlinks or hardlinks. Or is there some other > > > >> problem? > > > >> -Alan > > > > > > > > > > > > Yes it is. Well that's a bummer then. I thought we faked symlinks on > > > msdosfs, but on second thought not sure how well would do that. > > > > > > > > - Justin > > > > > > We should probably just remove the offending links on ppc, then. The > > > only harm is that after upgrading, ppc users would have to replace > > > fuse_load="YES" with fusefs_load="YES". > > > > > > > We should only do the Intel links on those platforms that have legacy users > > that need the old names. We should also only support the old names for one > > release or so. > > IIRC this was done so that the dropping of one of the drivers in ^head > could be merged back to ^stable. It probably should of been killed in > ^head after that fact, but if I recall the values correctly it was > @head=12 and merged to @stable=11. We would need to dig those facts > out, but yes, please, this link should be killed and cleaned up quickly as > it creates almost as many problems as it solved. Ignore most of that I had mixed the other time we did kernel module lnks (intel ethernet driver) with this insance for fuse. Though the principal idea of this should be a short lived compatibility hack still applies. > > Warner > -- > Rod Grimes rgrimes@freebsd.org -- Rod Grimes rgrimes@freebsd.org