From owner-svn-src-all@freebsd.org Sun Jun 17 02:52:35 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EF421009DDE for ; Sun, 17 Jun 2018 02:52:35 +0000 (UTC) (envelope-from juli@northcloak.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D27C07B3EA for ; Sun, 17 Jun 2018 02:52:34 +0000 (UTC) (envelope-from juli@northcloak.com) Received: by mail-qk0-x235.google.com with SMTP id w23-v6so7734354qkb.8 for ; Sat, 16 Jun 2018 19:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=northcloak-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6vVIxhs3mZnyIVx6CSnwdsuY+WWeHpdck5wha9ackOc=; b=lb4PY3n9AuzYb67P5sx6bFwhOkxUdpmPm+K0WwPAAfy88aknUPkLEBJz5TSc9jYUql KaQ0qWZbUx7Yj4ZSfifJIIMNkwbWwXaK4IIr7KNXMfvrvPdGnHVcgZFPKoeDKSPuYzf/ 3lf5Tu6xOBBIsh9zFPAILVwjiopmMPeogsdp7+1kPkrb5Aip2uQtr1QLNplzI5veabUt zU3a0z7aplm6K1dTYGTmplHlk3OvJORDqF0ddoUSsEbbgSr+brKlotcNh+kHlTvjXBJ4 17bvw6ZO6p3kAioNpsfKpfns8TReweWDfAYyP/ujBUPrmBnIfvXg0efr+YrtvsBSdooQ Z6Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6vVIxhs3mZnyIVx6CSnwdsuY+WWeHpdck5wha9ackOc=; b=jWUYl1ciI0IOgVzGijh6tiOeArBhCgEAJPUPUMgoIZ/GHcBW3KMNFqawxdwWWRZgab ToHf1YoEZWH+Ieaa6UFeKIrhtyHPTg1JhTWV7PjOHOP3pK4ZDzcwMst7p2zE0tmjh5vp lxhMv0dhNXZcGkHpfPEQbiR0XLpn9HW/SgFqlQ+BtOvJrKNDUNI/9z4qy8aj8PorHXn4 RU1Q4Jbl2E3Nh/KTqbc+5fiUbuARTruT6EvkqsawuCSgz3t9OLV1iOt44TqIfE2ynxQy ELsST9mchw+GAzsDxqijySLlRwXK9juM+v/OAbG2LnKZF9i1+CwFLP5eVLs9l/J4C24m K2VA== X-Gm-Message-State: APt69E30lAoocsT4WQGqfuNq7ExTgzE3R0h03Qk6dvmZ/g2SpDQMGnMJ deasrh6s30l9Sa2A4LCW6uvJcz/GwcwyCx7uuG9WrA== X-Google-Smtp-Source: ADUXVKIpP7sb2f43lfAj+4mAKXiIKpbzSC9XkdVB2tUyZE/r/gayRBdAhCVgl4ScnLKkqvUQ5lzaarl+zJg/wRw1qGI= X-Received: by 2002:a37:db09:: with SMTP id e9-v6mr6171020qki.63.1529203953979; Sat, 16 Jun 2018 19:52:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:2221:0:0:0:0:0 with HTTP; Sat, 16 Jun 2018 19:51:53 -0700 (PDT) In-Reply-To: <201806170243.w5H2haP5058197@pdx.rh.CN85.dnsmgr.net> References: <201806170243.w5H2haP5058197@pdx.rh.CN85.dnsmgr.net> From: Juli Mallett Date: Sat, 16 Jun 2018 19:51:53 -0700 Message-ID: Subject: Re: svn commit: r335270 - head/lib/liby To: rgrimes@freebsd.org Cc: Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 02:52:35 -0000 On 16 June 2018 at 19:43, Rodney W. Grimes wrote: > > On 16 June 2018 at 18:10, Rodney W. Grimes > > wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > >> Author: eadler > > >> Date: Sat Jun 16 23:50:34 2018 > > >> New Revision: 335270 > > >> URL: https://svnweb.freebsd.org/changeset/base/335270 > > >> > > >> Log: > > >> liby: build with WARNS=6 > > >> > > >> Tested with amd64, arm64, i386, mips > > >> > > >> Added: > > >> head/lib/liby/yyerror.h (contents, props changed) > > >> Modified: > > >> head/lib/liby/Makefile > > >> head/lib/liby/main.c > > >> head/lib/liby/yyerror.c > > >> > > >> Modified: head/lib/liby/Makefile > > >> ============================================================ > ================== > > >> --- head/lib/liby/Makefile Sat Jun 16 23:49:22 2018 > (r335269) > > >> +++ head/lib/liby/Makefile Sat Jun 16 23:50:34 2018 > (r335270) > > >> @@ -5,6 +5,4 @@ LIB= y > > >> SRCS= main.c yyerror.c > > >> NO_PIC= > > >> > > >> -WARNS?= 1 > > >> - > > >> .include > > >> > > >> Modified: head/lib/liby/main.c > > >> ============================================================ > ================== > > >> --- head/lib/liby/main.c Sat Jun 16 23:49:22 2018 > (r335269) > > >> +++ head/lib/liby/main.c Sat Jun 16 23:50:34 2018 > (r335270) > > >> @@ -32,16 +32,17 @@ > > >> #include > > >> __FBSDID("$FreeBSD$"); > > >> > > >> -#ifndef lint > > >> +#if defined(LIBC_SCCS) && !defined(lint) > > >> static char sccsid[] = "@(#)main.c 8.1 (Berkeley) 6/4/93"; > > >> -#endif /* not lint */ > > >> +#endif /* LIBC_SCCS and not lint */ > > >> > > >> #include > > >> > > >> -int yyparse(void); > > >> +#include "yyerror.h" > > >> > > >> int > > >> main(void) > > >> { > > >> + > > >> exit(yyparse()); > > >> } > > >> > > >> Modified: head/lib/liby/yyerror.c > > >> ============================================================ > ================== > > >> --- head/lib/liby/yyerror.c Sat Jun 16 23:49:22 2018 > (r335269) > > >> +++ head/lib/liby/yyerror.c Sat Jun 16 23:50:34 2018 > (r335270) > > >> @@ -32,16 +32,18 @@ > > >> #include > > >> __FBSDID("$FreeBSD$"); > > >> > > >> -#ifndef lint > > >> +#if defined(LIBC_SCCS) && !defined(lint) > > >> static char sccsid[] = "@(#)yyerror.c 8.1 (Berkeley) 6/4/93"; > > >> -#endif /* not lint */ > > >> +#endif /* LIBC_SCCS and not lint */ > > >> > > >> #include > > >> > > >> +#include "yyerror.h" > > >> + > > >> int > > >> -yyerror(msg) > > >> -char *msg; > > >> +yyerror(const char *msg) > > >> { > > >> - (void)fprintf(stderr, "%s\n", msg); > > >> + > > >> + fprintf(stderr, "%s\n", msg); > > >> return(0); > > >> } > > >> > > >> Added: head/lib/liby/yyerror.h > > >> ============================================================ > ================== > > >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > >> +++ head/lib/liby/yyerror.h Sat Jun 16 23:50:34 2018 > (r335270) > > >> @@ -0,0 +1,36 @@ > > > > > > Where did this file come from???? > > > > I added a header file instead of keeping the prototypes in the .c > > files. Is something wrong with that? > > If you extracted part of a c file and placed it in a .h file, you > should add a > * from: pathname > comment to this yyerror.h > Rod, It's two prototypes. For functions that are extern. Including the UCB copyright isn't even necessary, but seems reasonable. No, people do not need to add "from:" notes when adding a header to provide prototypes for extern functions. Juli. > What flagged me was we shouldnt just have spontanious files arriving > from 1990/1993 UCB. > > Thanks, > Rod > > @@ -0,0 +1,36 @@ > +/*- > + * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 1990, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > > -- > Rod Grimes > rgrimes@freebsd.org > >