From owner-svn-ports-all@freebsd.org  Mon Jun 25 07:08:26 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F5E9102813B;
 Mon, 25 Jun 2018 07:08:26 +0000 (UTC) (envelope-from lars@e.0x20.net)
Received: from mail.0x20.net (mail.0x20.net [46.251.251.56])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "0x20.net",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1E8E98E8D5;
 Mon, 25 Jun 2018 07:08:25 +0000 (UTC) (envelope-from lars@e.0x20.net)
Received: from e.0x20.net (mail.0x20.net [46.251.251.56])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.0x20.net (Postfix) with ESMTPS id CE27A54D42;
 Mon, 25 Jun 2018 09:08:15 +0200 (CEST)
Received: (from lars@localhost)
 by e.0x20.net (8.15.2/8.15.2/Submit) id w5P78F6U061357;
 Mon, 25 Jun 2018 09:08:15 +0200 (CEST) (envelope-from lars)
Date: Mon, 25 Jun 2018 09:08:15 +0200
From: Lars Engels <lars.engels@0x20.net>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: Michael Danilov <mike.d.ft402@gmail.com>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r472962 - head/net-mgmt/aircrack-ng
Message-ID: <20180625070815.GA22494@e.0x20.net>
References: <201806210759.w5L7x2cJ042398@repo.freebsd.org>
 <alpine.LSU.2.21.1806221205330.3747@anthias.pfeifer.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.21.1806221205330.3747@anthias.pfeifer.com>
X-Editor: VIM - Vi IMproved 8.0
User-Agent: Mutt/1.10.0 (2018-05-17)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jun 2018 07:08:26 -0000

On Sat, Jun 23, 2018 at 12:51:31AM +0200, Gerald Pfeifer wrote:
> Hi Lars and Michael,
> 
> On Thu, 21 Jun 2018, Lars Engels wrote:
> >   - Set required GCC version to 6+, so that the default gcc version is chosen.
> >   GCC isn't needed to successfully building the port, but according to upstream
> >
> >   PR:		228747
> >   Submitted by:	Michael Danilov <mike.d.ft402@gmail.com>
> 
> > -USE_GCC=	7+
> > +USE_GCC=	6+
> 
> in that case, the canonical way to state that is
> 
>   USE_GCC=	yes
> 
> which has the advantage that it'll do what you are aiming for,
> without a need to adjust as the default version moves (or if
> some user changes the default via Mk/bsd.default-versions.mk).
> 
> I'll be happy to make this change if you agree.

Hello Gerald,

thanks for the explanation. Feel free to commit the fix.

Thanks in advance

Lars