Date: Wed, 07 Dec 2016 01:43:55 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 215105] link_aton() hex formatting breakage in today's patch Message-ID: <bug-215105-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215105 Bug ID: 215105 Summary: link_aton() hex formatting breakage in today's patch Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: jtd2004a@sbcglobal.net The recently issued patch for security issue FreeBSD-SA-16:36.libc has three problems affecting the link_ntoa() function. 1. Hex digits are reversed in order: 0x27 is represented as 72, etc. This = is because the old code wrote out[1] then out[0]; the new code writes *out++ a= nd *out++ in the same order. 2. Accounting of buffer space is bad: In the single-digit case, it has 'rem= ++' but should probably have 'rem--' instead. 3. Bytes in the range 0x80-0xff are represented badly, for instance 0x84 is represented by backslash in my test environment. This appears to result fr= om 'char' and 'int' being signed, in the 'if (i > 0xf)'. This one might also depend on my very unusual system. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-215105-8>