From owner-cvs-all Tue Feb 5 14:45:39 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 2047E37B427; Tue, 5 Feb 2002 14:45:35 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g15MjUT09437; Wed, 6 Feb 2002 01:45:31 +0300 (MSK) (envelope-from ache) Date: Wed, 6 Feb 2002 01:45:29 +0300 From: "Andrey A. Chernov" To: Mark Murray Cc: des@freebgsd.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.c Message-ID: <20020205224527.GA9394@nagual.pp.ru> References: <20020205220620.GD8579@nagual.pp.ru> <200202052235.g15MZYs33989@greenpeace.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200202052235.g15MZYs33989@greenpeace.grondar.org> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Feb 05, 2002 at 22:35:29 +0000, Mark Murray wrote: > > In my opinion, your program was a god example of how _not_ to do it. :-) Program just knows nothing about undocumented PAM internal random() clobbering. And don't need to know anything about that in general. Do you expect that each writer must analyze pam_unix() code before starting using random() in his program? If so, it should be documented even in random(4) manpage. General rule is: general purpose libraries should minimize unpredicatble and undocumented side effects. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message