From owner-svn-src-head@freebsd.org Wed Apr 29 18:13:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 23C4C2BDA44 for ; Wed, 29 Apr 2020 18:13:03 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49C67f0TY5z4bVv for ; Wed, 29 Apr 2020 18:13:01 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lf1-f65.google.com with SMTP id u10so2496334lfo.8 for ; Wed, 29 Apr 2020 11:13:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uknjBQ+QEF7OJWtxRW/xHx0iUtWVOrfr/PBfjgGAIJA=; b=C3bdnnQynFpe9y9RySwNLqBcNcWO92IjJljJglPbcancQCFrC6FtNgxoXzJ+swZNqk DHJdtHSOM3LHNN0UGzFC3nQVknmm2lf9umlPR5Mf3+4W7Ivoi7R9O2ukczHp2yVU5QSv DY7i4s12IQyk1bScr9OXyBvQ5b2NkZhlI2w8XpN8+UL5RXm2QpJ39zalD2h745OhJViR QpIhl4J2nV3u8jhipaDw80mIGUvQt4ZrYkNcCaIie0vGsYm4edsvcktaPBu5CVyZjq0S 8BgfdMulaULE+I4XeKTVo36lLhbMSyJWB1buFmvqvBQrMu59h+NdrVmFTLOoFmuy6Cxb ZNzA== X-Gm-Message-State: AGi0PuZ/M40t1fJECNQRGKsIlmeSccomJkktfFUqH126Clxl2gWz/KsW 3xVIZ/6zgVYmiXt6VK2aHPW02495 X-Google-Smtp-Source: APiQypJ/QWocVXPmwB8DYfJqF3Wnvb2Ml4gWWTSxK1f62xWlYXzSd52JcYDjeNvhJyctJl8QbSFwiQ== X-Received: by 2002:a05:6512:1095:: with SMTP id j21mr23679968lfg.118.1588183979719; Wed, 29 Apr 2020 11:12:59 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id e20sm2924566lja.81.2020.04.29.11.12.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 11:12:58 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id u10so2496249lfo.8 for ; Wed, 29 Apr 2020 11:12:58 -0700 (PDT) X-Received: by 2002:a19:f806:: with SMTP id a6mr23772383lff.201.1588183978317; Wed, 29 Apr 2020 11:12:58 -0700 (PDT) MIME-Version: 1.0 References: <202004272202.03RM2iR2012757@repo.freebsd.org> <122841588148797@mail.yandex.ru> In-Reply-To: <122841588148797@mail.yandex.ru> From: Eric Joyner Date: Wed, 29 Apr 2020 11:12:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r360398 - head/sys/net To: Aleksandr Fedorov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 49C67f0TY5z4bVv X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.167.65 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-0.94 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; URI_COUNT_ODD(1.00)[9]; RCVD_COUNT_THREE(0.00)[4]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; FREEMAIL_TO(0.00)[yandex.ru]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.95)[-0.954,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-0.96)[-0.960,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[65.167.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.03)[ip: (0.72), ipnet: 209.85.128.0/17(-0.40), asn: 15169(-0.43), country: US(-0.05)]; RWL_MAILSPIKE_POSSIBLE(0.00)[65.167.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 18:13:03 -0000 Hi Aleksandr, Part of this patch was to introduce a driver-dependent iflib function that would allow drivers to tell iflib whether or not to flap the interface when a vlan is registered or unregistered. I think this could be fixed for em(4) by having it implement that function to either always return false (so iflib doesn't do an init/stop), or maybe have it only do a reset when vlanhwfilter is enabled; I'm going to take a look at doing that. - Eric On Wed, Apr 29, 2020 at 1:27 AM Aleksandr Fedorov wrote: > Sorry for the late response, but I think that this changes makes Intel > cards with iflib drivers fully unusable. > We already have a regression which leads to an interface flapping > when adding vlan with enabled vlanhwfilter. But at least there is a > workaround - disabling hwfilter. > After this change, the interface will always flap. > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241785 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240818 > https://lists.freebsd.org/pipermail/freebsd-net/2018-November/052184.html > >