Date: Fri, 4 May 2012 13:11:09 -0400 From: John Baldwin <jhb@freebsd.org> To: Hans Petter Selasky <hselasky@c2i.net> Cc: "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-stable-9@freebsd.org" <svn-src-stable-9@freebsd.org> Subject: Re: svn commit: r235007 - stable/9/sys/dev/pci Message-ID: <201205041311.09237.jhb@freebsd.org> In-Reply-To: <201205041826.19435.hselasky@c2i.net> References: <201205041538.q44FclqK010547@svn.freebsd.org> <201205041214.16342.jhb@freebsd.org> <201205041826.19435.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, May 04, 2012 12:26:19 pm Hans Petter Selasky wrote: > On Friday 04 May 2012 18:14:16 John Baldwin wrote: > > On Friday, May 04, 2012 11:38:47 am Hans Petter Selasky wrote: > > > Author: hselasky > > > Date: Fri May 4 15:38:47 2012 > > > New Revision: 235007 > > > URL: http://svn.freebsd.org/changeset/base/235007 > > > > > > Log: > > > MFC r233662, r233677 and r233678: > > > > > > Writing zero to BAR actually does not disable it and > > > it is even harmful as hselasky found out. Historically, > > > this code was originated from (OLDCARD) CardBus driver and later leaked > > > into PCI driver when CardBus was newbus'ified and refactored with PCI > > > driver. However, it is not really necessary even for CardBus. > > > > FYI, I've got one bug report on HEAD where these changes broke a machine's > > ATA controller. > > Have you considered adding code to disable the I/O or memory range instead of > writing 0 to the bar in this case? I have to figure out what the user's bug is first. The patch that "fixed" it was to restore writing 0 to a BAR that failed to allocate during the initial bus scan. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205041311.09237.jhb>