From owner-freebsd-current@FreeBSD.ORG Thu Mar 23 16:14:33 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E52316A41F; Thu, 23 Mar 2006 16:14:33 +0000 (UTC) (envelope-from nork@FreeBSD.org) Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1077643D48; Thu, 23 Mar 2006 16:14:23 +0000 (GMT) (envelope-from nork@FreeBSD.org) Received: from melfina.ninth-nine.com (melfina.ninth-nine.com [192.168.36.6]) (authenticated bits=0) by sakura.ninth-nine.com (8.13.4/8.13.4/NinthNine) with ESMTP id k2NGEFU8038560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 24 Mar 2006 01:14:16 +0900 (JST) (envelope-from nork@FreeBSD.org) Date: Fri, 24 Mar 2006 01:14:16 +0900 From: Norikatsu Shigemura To: obrien@FreeBSD.org, scott_long@btc.adaptec.com, mark_salyzyn@adaptec.com Message-Id: <20060324011416.acd8df42.nork@FreeBSD.org> In-Reply-To: <20060323213143.30d26b6e.nork@FreeBSD.org> References: <20060323213143.30d26b6e.nork@FreeBSD.org> X-Mailer: Sylpheed version 2.2.3 (GTK+ 2.8.16; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (sakura.ninth-nine.com [219.127.74.121]); Fri, 24 Mar 2006 01:14:16 +0900 (JST) Cc: vkashyap@FreeBSD.org, freebsd-current@FreeBSD.org Subject: asr(4) doesn't depend on cam(4) and pci(4). X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2006 16:14:33 -0000 Hi asr(4) maintainers! On Thu, 23 Mar 2006 21:31:43 +0900 Norikatsu Shigemura wrote: > I found a bug that twa(4)'s module doesn't depend on cam(4) > and pci(4). Please commit following patch and MFC. > I think that there are same bugs in many driver depended on > cam(4) like advansys(4), aha(4), ahb(4), amr(4), arcmsr(4), > asr(4), .... > I confirmed following way: (compare following result) > # cd /usr/src/sys/dev > # fgrep -l xpt_ */*.c > # fgrep MODULE_DEPEND `fgrep -l xpt_ */*.c` > So I might miss. > Index: tw_osl_freebsd.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/twa/tw_osl_freebsd.c,v > retrieving revision 1.4 > diff -u -r1.4 tw_osl_freebsd.c > --- tw_osl_freebsd.c 8 Nov 2005 22:51:43 -0000 1.4 > +++ tw_osl_freebsd.c 23 Mar 2006 12:20:29 -0000 > @@ -207,6 +207,8 @@ > }; > > DRIVER_MODULE(twa, pci, twa_pci_driver, twa_devclass, 0, 0); > +MODULE_DEPEND(sym, cam, 1, 1, 1); > +MODULE_DEPEND(sym, pci, 1, 1, 1); > > > I have a patch for asr(4), too. Please, please:-). Index: asr.c =================================================================== RCS file: /home/ncvs/src/sys/dev/asr/asr.c,v retrieving revision 1.77 diff -u -r1.77 asr.c --- asr.c 12 Feb 2006 06:57:41 -0000 1.77 +++ asr.c 23 Mar 2006 16:08:04 -0000 @@ -429,6 +429,8 @@ static devclass_t asr_devclass; DRIVER_MODULE(asr, pci, asr_driver, asr_devclass, 0, 0); +MODULE_DEPEND(sym, cam, 1, 1, 1); +MODULE_DEPEND(sym, pci, 1, 1, 1); /* * devsw for asr hba driver