Date: Fri, 24 Mar 2006 01:14:16 +0900 From: Norikatsu Shigemura <nork@FreeBSD.org> To: obrien@FreeBSD.org, scott_long@btc.adaptec.com, mark_salyzyn@adaptec.com Cc: vkashyap@FreeBSD.org, freebsd-current@FreeBSD.org Subject: asr(4) doesn't depend on cam(4) and pci(4). Message-ID: <20060324011416.acd8df42.nork@FreeBSD.org> In-Reply-To: <20060323213143.30d26b6e.nork@FreeBSD.org> References: <20060323213143.30d26b6e.nork@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi asr(4) maintainers! On Thu, 23 Mar 2006 21:31:43 +0900 Norikatsu Shigemura <nork@freebsd.org> wrote: > I found a bug that twa(4)'s module doesn't depend on cam(4) > and pci(4). Please commit following patch and MFC. > I think that there are same bugs in many driver depended on > cam(4) like advansys(4), aha(4), ahb(4), amr(4), arcmsr(4), > asr(4), .... > I confirmed following way: (compare following result) > # cd /usr/src/sys/dev > # fgrep -l xpt_ */*.c > # fgrep MODULE_DEPEND `fgrep -l xpt_ */*.c` > So I might miss. > Index: tw_osl_freebsd.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/twa/tw_osl_freebsd.c,v > retrieving revision 1.4 > diff -u -r1.4 tw_osl_freebsd.c > --- tw_osl_freebsd.c 8 Nov 2005 22:51:43 -0000 1.4 > +++ tw_osl_freebsd.c 23 Mar 2006 12:20:29 -0000 > @@ -207,6 +207,8 @@ > }; > > DRIVER_MODULE(twa, pci, twa_pci_driver, twa_devclass, 0, 0); > +MODULE_DEPEND(sym, cam, 1, 1, 1); > +MODULE_DEPEND(sym, pci, 1, 1, 1); > > > I have a patch for asr(4), too. Please, please:-). Index: asr.c =================================================================== RCS file: /home/ncvs/src/sys/dev/asr/asr.c,v retrieving revision 1.77 diff -u -r1.77 asr.c --- asr.c 12 Feb 2006 06:57:41 -0000 1.77 +++ asr.c 23 Mar 2006 16:08:04 -0000 @@ -429,6 +429,8 @@ static devclass_t asr_devclass; DRIVER_MODULE(asr, pci, asr_driver, asr_devclass, 0, 0); +MODULE_DEPEND(sym, cam, 1, 1, 1); +MODULE_DEPEND(sym, pci, 1, 1, 1); /* * devsw for asr hba driver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060324011416.acd8df42.nork>