From owner-svn-src-all@FreeBSD.ORG Tue Apr 14 18:15:28 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13CF31065D8A; Tue, 14 Apr 2009 18:15:28 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from kientzle.com (kientzle.com [66.166.149.50]) by mx1.freebsd.org (Postfix) with ESMTP id CD7718FC13; Tue, 14 Apr 2009 18:15:27 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: (from root@localhost) by kientzle.com (8.14.3/8.14.3) id n3EIFRPK085132; Tue, 14 Apr 2009 11:15:27 -0700 (PDT) (envelope-from kientzle@freebsd.org) Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2]) by kientzle.com with SMTP id 8tx3cevexbcvvtdhm7yvzt4ips; Tue, 14 Apr 2009 11:15:27 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <49E4D2BF.2040503@freebsd.org> Date: Tue, 14 Apr 2009 11:15:27 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.21) Gecko/20090409 SeaMonkey/1.1.15 MIME-Version: 1.0 To: Edward Tomasz Napierala References: <200904141139.n3EBdudA004806@svn.freebsd.org> In-Reply-To: <200904141139.n3EBdudA004806@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191055 - head/lib/libc/string X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2009 18:15:33 -0000 Edward Tomasz Napierala wrote: > Author: trasz > Date: Tue Apr 14 11:39:56 2009 > New Revision: 191055 > URL: http://svn.freebsd.org/changeset/base/191055 > > Log: > There is no way for strmode(3) to append '+' if the file has ACL, > because there is no way to figure that out based on the file mode > itself. Make the manual page match reality. Yep, that '+' is why libarchive has a custom strmode() that accepts more information than just the mode. A related issue: It would be really nice to be able to find out whether a file had extended ACLs or extended attributes based on the information returned from stat(2). That would allow programs like tar to avoid a fair number of system calls. Even just a single bit "HAS_EXTENSIONS" would help a lot, since most files don't have any extended ACLs or extended attributes. It would also allow users of strmode() (such as ls) to insert that '+' sign themselves. The only place I see to do this is to appropriate some bits from st_flags. Tim