From owner-cvs-all Mon Mar 3 13: 2:15 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C288437B401; Mon, 3 Mar 2003 13:02:12 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2EEA43FD7; Mon, 3 Mar 2003 13:02:11 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.6/8.12.5) with SMTP id h23L1YP4098945; Mon, 3 Mar 2003 16:01:34 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Mon, 3 Mar 2003 16:01:33 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Nate Lawson Cc: Jeff Roberson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_default.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 3 Mar 2003, Nate Lawson wrote: > On Mon, 3 Mar 2003, Jeff Roberson wrote: > > On Mon, 3 Mar 2003, Nate Lawson wrote: > > > Modified files: > > > sys/kern vfs_default.c > > > Log: > > > Pick up one file missed in the previous vprint() cleanup > > > > > Hey, good work here. Do you think there would be any way to use the > > vnode's char name in the generic sync routine? There are a few other > > places where we msleep that could use a more specific name as well. > > Interesting idea but how would you suggest compressing that to 6 chars? > I assume "show lockedvnodes" will always be supreme? And when I just > glanced at the implementation of "show lockedvnodes", I noticed: > mtx_lock(&mountlist_mtx); How can this be correct? It's not. I've been meaning to remove the locking from ddb for ages, and I think Bruce also had patches floating around at one point. BTW, we now get some fascinating failure modes if you do: call boot(0) in ddb, since it runs in an interrupt context using a serial console, and when the shutdown sequence tries to malloc storage, it panics... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message