From owner-svn-src-head@freebsd.org Thu Apr 19 16:49:51 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33617F8C140; Thu, 19 Apr 2018 16:49:51 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C87E282AD6; Thu, 19 Apr 2018 16:49:50 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id C7D555A9F12; Thu, 19 Apr 2018 16:49:43 +0000 (UTC) Date: Thu, 19 Apr 2018 16:49:43 +0000 From: Brooks Davis To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332782 - in head/sys: amd64/linux amd64/linux32 compat/freebsd32 i386/linux kern sys Message-ID: <20180419164943.GA84360@spindle.one-eyed-alien.net> References: <201804191600.w3JG0Y0w077991@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <201804191600.w3JG0Y0w077991@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 16:49:51 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 19, 2018 at 04:00:34PM +0000, John Baldwin wrote: > Author: jhb > Date: Thu Apr 19 16:00:34 2018 > New Revision: 332782 > URL: https://svnweb.freebsd.org/changeset/base/332782 >=20 > Log: > Simplify the code to allocate stack for auxv, argv[], and environment v= ectors. > =20 > Remove auxarg_size as it was only used once right after a confusing > assignment in each of the variants of exec_copyout_strings(). Thanks! I just tripped over auxarg_size's confusing nature in CheriBSD. I do wonder if allocating AT_COUNT entries is quite right since some are emitted only optionally. That said, it's not as though the waste is significant. -- Brooks --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJa2MinAAoJEKzQXbSebgfAqncH/1QJGadgYQpo58lkuhbLSgJS LWlPZVVr7vn5+rAOhsODmYaXpJib1Ylukn5ik0yse4YSx8mLoEAIK9ewf7E2Wr67 hnRFeK6SwXFNi2TqqS+mdv/YQ92LrOx57TDywD5dKqTma2sHSwe28NAAICVm4WZG oUuS7NgDYzckQtnJxWqp7tuZsTbzofwMwH5CkzhNmBMj3QAmT60oEqvBFLe55rLE VPqPb1rW8xCiMJIeXLCeynb50YRjAMlZcvKtnFHDVAP+eV0x8fzQqQUPGM3Kp1hX zmsDdeGsPtFN9hNT/yq6Ea1HnpAldoNmfdRyvBSRh0qa7ny92tdIuQlkoIn05N4= =JyDk -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--