From owner-freebsd-bugs Sun Jul 15 11:40:33 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 56D3F37B40C for ; Sun, 15 Jul 2001 11:40:26 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f6FIeQt03713; Sun, 15 Jul 2001 11:40:26 -0700 (PDT) (envelope-from gnats) Date: Sun, 15 Jul 2001 11:40:26 -0700 (PDT) Message-Id: <200107151840.f6FIeQt03713@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: SASAKI Taroh Subject: Re: bin/28990: ftp(1) has stack overflow when "mget *", etc. Reply-To: SASAKI Taroh Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/28990; it has been noted by GNATS. From: SASAKI Taroh To: Chris Faulhaber Cc: SASAKI Taroh , freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/28990: ftp(1) has stack overflow when "mget *", etc. Date: Mon, 16 Jul 2001 03:34:40 +0900 hi, At Sun, 15 Jul 2001 13:23:58 -0400, Chris Faulhaber wrote: > > ! for (mode = "w", ++argv; *argv != NULL; argv++, mode = "a") (snip) > > ! for (mode = "w"; *++argv != NULL; mode = "a") > I don't seem to be able to locate this piece of code in util.c. > According to cvsweb, the 'fix' has been in the tree since rev 1.1. sorry, my mistake. that's because the diff arguments are in reverse order (diff NEW OLD): > > *** usr/src/usr.bin/ftp/util.c Mon Jul 16 00:45:11 2001 > > --- usr/src/usr.bin/ftp/util.c.org Mon Jul 16 00:37:57 2001 thanks, * Please don't attach any application dependent (e.g. MS-Excel or Word) file. I'll NEVER open it for the sake of protecting the network. --- SASAKI, Taroh | When you go on this road, never be anxious.| mailto:taroh@taroh.org| If you fear, there's no road.| http://www.taroh.org/ | ??? If you step, that'll be a road.| phone://81/908/50/76728 % Go, don't be hesitate. You will know.| icq:19785633 | ********** *** --- Ikkyu, the Bonze | address:jp/221/0005/4/541/1/203A **** ----------------------------+ global:/wgs84/n35/30/06.9/e139/38/14.6/h29 pgpfingerprint:4C/6A/E6/0E/D5/A1/DA/AC/54/8F/94/E9/E3/F2/9C/08 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message