From owner-freebsd-ports@FreeBSD.ORG  Sun Sep 14 22:07:33 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DC12516A4BF
	for <ports@FreeBSD.org>; Sun, 14 Sep 2003 22:07:33 -0700 (PDT)
Received: from mx2.fillmore-labs.com (lima.fillmore-labs.com [62.138.193.83])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CE5FA43F3F
	for <ports@FreeBSD.org>; Sun, 14 Sep 2003 22:07:32 -0700 (PDT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from pd951ac01.dip.t-dialin.net
	([217.81.172.1] helo=fillmore-labs.com ident=fjjljm7p8001gqyz)
	by mx2.fillmore-labs.com with asmtp (TLSv1:AES256-SHA:256)
	(Exim 4.22)
	id 19ylaE-0008rK-9v; Mon, 15 Sep 2003 07:07:30 +0200
Message-ID: <3F65490A.7060403@fillmore-labs.com>
Date: Mon, 15 Sep 2003 07:07:22 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
MIME-Version: 1.0
To: Sergey Matveychuk <sem@ciam.ru>
References: <20030914153245.79ba8838.tkato@prontomail.com>
	<3F644E7A.1040806@fillmore-labs.com>
	<20030914230644.447e9891.tkato@prontomail.com>
	<3F6479F7.6040706@fillmore-labs.com>
	<20030915023557.5434f58c.tkato@prontomail.com>
	<3F64D002.5010605@fillmore-labs.com> <3F653E66.9040601@ciam.ru>
In-Reply-To: <3F653E66.9040601@ciam.ru>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: eikemeier@fillmore-labs.com
User-Agent: KMail/1.5.9
Organization: Fillmore Labs GmbH  <http://www.fillmore-labs.com/>
X-Complaints-To: abuse@fillmore-labs.com
cc: FreeBSD ports <ports@FreeBSD.org>
Subject: Re: PRs  ports/56767...56858
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: FreeBSD ports <ports@FreeBSD.org>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Sep 2003 05:07:34 -0000

Sergey Matveychuk wrote:

> Oliver Eikemeier wrote:
> 
>> KATO Tsuguru wrote:
>>
>>> The function you want is availabe if "ECHO_MSG=${ECHO}" is
>>> added to /etc/make.conf. Perhaps this way is appropriate
>>> to become default value....
>>
>> Hmmm... I consider it silly if a port tells me
>> 'YOU CAN BUILD ME WITH THE FOLLOWING OPTIONS' if I just do
>> a makesum or checksum. Most of the ports save me their
>> messages, but tell me when something goes wrong. It does not
>> work with every port, but I would like it if bento
>> builds with -s by default, that will save us the
>> repeated option reminders on a lot of ports.
>>
>> Redefining ECHO_MSG is definetively bad, because it kills
>> every error message.
> 
> Agree. I think we need to have different ECHO* command: for ports system 
> messages and errors, and port specific notify messages.
> It's not obviously now what I need to use ECHO, ECHO_CMD or ECHO_MSG and 
> when.

Ok, a proposal:

ECHO_CMD => not suppressable

  for the last message before you die or when something should be
  written to a file, pipe, etc. Also when an output is the result
  of the build (ie 'make maintainer`).

ECHO_MSG => suppressable, but not likely to be

  build progress, error messages, warnings, anything short relating
  to the current build. An error free build should produce the same
  results with ECHO_MSG=${TRUE}

ECHO => suppressable
  anything you want the user to know, but may be known by having read
  it before or anything that is not important in a non-interactive
  environment (portupgrade or bento) and can be deduced by reading
  the makefile.