From owner-freebsd-pf@freebsd.org  Thu Mar 30 04:38:33 2017
Return-Path: <owner-freebsd-pf@freebsd.org>
Delivered-To: freebsd-pf@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03364D25401
 for <freebsd-pf@mailman.ysv.freebsd.org>; Thu, 30 Mar 2017 04:38:33 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E7566181
 for <freebsd-pf@FreeBSD.org>; Thu, 30 Mar 2017 04:38:32 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2U4cWEg091439
 for <freebsd-pf@FreeBSD.org>; Thu, 30 Mar 2017 04:38:32 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-pf@FreeBSD.org
Subject: [Bug 217997] [pf] orphaned entries in src-track
Date: Thu, 30 Mar 2017 04:38:33 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.3-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: maximos@als.nnov.ru
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-pf@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-217997-17777-5p2U8FAERx@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217997-17777@https.bugs.freebsd.org/bugzilla/>
References: <bug-217997-17777@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf/>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 04:38:33 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217997

--- Comment #8 from Max <maximos@als.nnov.ru> ---
I think the problem is in pf_create_state():

        /* check maximums */
        if (r->max_states &&
            (counter_u64_fetch(r->states_cur) >=3D r->max_states)) {
                counter_u64_add(V_pf_status.lcounters[LCNT_STATES], 1);
                REASON_SET(&reason, PFRES_MAXSTATES);
                return (PF_DROP);
        }

We can't just return here. Arguably we should "goto csfailed;" instead.

--=20
You are receiving this mail because:
You are the assignee for the bug.=