Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Mar 2017 04:38:33 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-pf@FreeBSD.org
Subject:   [Bug 217997] [pf] orphaned entries in src-track
Message-ID:  <bug-217997-17777-5p2U8FAERx@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217997-17777@https.bugs.freebsd.org/bugzilla/>
References:  <bug-217997-17777@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217997

--- Comment #8 from Max <maximos@als.nnov.ru> ---
I think the problem is in pf_create_state():

        /* check maximums */
        if (r->max_states &&
            (counter_u64_fetch(r->states_cur) >=3D r->max_states)) {
                counter_u64_add(V_pf_status.lcounters[LCNT_STATES], 1);
                REASON_SET(&reason, PFRES_MAXSTATES);
                return (PF_DROP);
        }

We can't just return here. Arguably we should "goto csfailed;" instead.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217997-17777-5p2U8FAERx>