From owner-freebsd-current@freebsd.org Mon Jul 20 03:25:41 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4027D9A6672 for ; Mon, 20 Jul 2015 03:25:41 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by mx1.freebsd.org (Postfix) with ESMTP id C5915280E for ; Mon, 20 Jul 2015 03:25:40 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ppp118-210-21-62.lns20.adl2.internode.on.net (HELO midget.dons.net.au) ([118.210.21.62]) by ipmail07.adl2.internode.on.net with ESMTP; 20 Jul 2015 12:55:30 +0930 Received: from maelstrom.dons.net.au (Maelstrom.dons.net.au [10.0.2.104]) (authenticated bits=0) by midget.dons.net.au (8.15.1/8.14.9) with ESMTPSA id t6K3P9o1061193 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Jul 2015 12:55:15 +0930 (CST) (envelope-from darius@dons.net.au) Subject: Re: -current broken when MAKEOBJDIRPREFIX is set (was: src is on NFS) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: text/plain; charset=us-ascii From: "O'Connor, Daniel" In-Reply-To: <14459.1437358244@chaos> Date: Mon, 20 Jul 2015 12:55:09 +0930 Cc: Tim Kientzle , Rick Macklem , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <1CF5CFB9-81B3-4AAF-BD4B-8B7A66EFD031@dons.net.au> References: <1C5FC434-0646-40E5-83AC-A0DE486D3273@dons.net.au> <1589003792.10086361.1437048709012.JavaMail.zimbra@uoguelph.ca> <6668.1437240399@chaos> <15209.1437332341@chaos> <14459.1437358244@chaos> To: "Simon J. Gerraty" X-Mailer: Apple Mail (2.2102) X-Spam-Score: -4.216 () ALL_TRUSTED,BAYES_00,RP_MATCHES_RCVD,URIBL_BLOCKED X-Scanned-By: MIMEDefang 2.75 on 10.0.2.1 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2015 03:25:41 -0000 > On 20 Jul 2015, at 11:40, Simon J. Gerraty wrote: >=20 > O'Connor, Daniel wrote: >>>> So, it seems MAKEOBJDIRPREFIX only works as an environmental = variable >=20 >> Weird, I could have sworn I have set it on the command line and had = it >> work, but.. >=20 > In most "normal" usage you will likely not notice a difference. > It is only when a makefile is "being clever" that things go south when > you break its expectations. I guess, buildworld is pretty clever though :) >>> I thought there was a check in src/Makefile for that. >>=20 >> Not so far as I can tell - it certainly gets quite far before blowing >> up with a non useful error message :) >=20 > The check in src/Makefile is only guarding against MAKEOBJDIRPREFIX = set > in say make.conf, it explicitly discards the possibility of setting > MAKEOBJDIRPREFIX on command line - which seems wrong. >=20 > Also with bmake, you *can* usefully set MAKEOBJDIRPREFIX in a makefile > since the choice of .OBJDIR can be made after make starts reading > makefiles. >=20 > So the current test is perhaps out dated on that score too - though > only if something like auto.obj.mk is being used (-DWITH_AUTO_OBJ) > which I don't think I've tested with buildworld. I know sod all about *make but as an 'end user' a seat belt to warn = about this problem would be Really Nice (tm). -- Daniel O'Connor "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C