From owner-freebsd-current@FreeBSD.ORG Wed Sep 28 20:02:44 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95FBA16A41F for ; Wed, 28 Sep 2005 20:02:44 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C21C43D4C for ; Wed, 28 Sep 2005 20:02:44 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j8SK2hVQ017071 for ; Wed, 28 Sep 2005 13:02:43 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j8SK2hsK017070 for current@freebsd.org; Wed, 28 Sep 2005 13:02:43 -0700 Date: Wed, 28 Sep 2005 13:02:43 -0700 From: Brooks Davis To: current@freebsd.org Message-ID: <20050928200243.GA16219@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: Subject: [brooks@FreeBSD.ORG: [src] cvs commit: src/etc pccard_ether] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2005 20:02:44 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I've just committed the following change to /etc/pccard_ether. I think it's the right solution, but I'm concerned it may cause problems with drivers that incorrectly frob the IFF_UP flag themselves. If so it may be nessicary to revert this change temporarily or at least not MFC it. -- Brooks ----- Forwarded message from Brooks Davis ----- From: Brooks Davis Date: Wed, 28 Sep 2005 19:59:23 +0000 (GMT) To: brooks@FreeBSD.ORG Subject: [src] cvs commit: src/etc pccard_ether brooks 2005-09-28 19:59:18 UTC FreeBSD src repository Modified files: etc pccard_ether=20 Log: Be less IPv4 centric. When checking if the interface is already configured, check if the UP flag is set instead of checking for the netmask keyword. =20 Revision Changes Path 1.47 +1 -1 src/etc/pccard_ether Index: src/etc/pccard_ether diff -u src/etc/pccard_ether:1.46 src/etc/pccard_ether:1.47 --- src/etc/pccard_ether:1.46 Wed Aug 24 01:23:49 2005 +++ src/etc/pccard_ether Wed Sep 28 19:59:18 2005 @@ -71,7 +71,7 @@ case ${startstop} in [Ss][Tt][Aa][Rr][Tt] | '') if [ -x /usr/bin/grep ]; then - if ifconfig $ifn | grep -s netmask > /dev/null 2>&1; then + if ifconfig $ifn | grep -s '[<,]UP[,>]' > /dev/null 2>&1; then # Interface is already up, so ignore it. exit 0 fi ----- End forwarded message ----- --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDOvbiXY6L6fI4GtQRArN6AJsGkBeSp1CRCpCl3q/fG/q82XdYDQCcD2n3 T9ySdSt7gqspNfz1Lq3R+d8= =u12i -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--