From owner-freebsd-ports-bugs@freebsd.org  Tue Aug 18 21:17:01 2015
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 344709BCE49
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Tue, 18 Aug 2015 21:17:01 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 208AF225
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 18 Aug 2015 21:17:01 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7ILH0wA069642
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 18 Aug 2015 21:17:00 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile
Date: Tue, 18 Aug 2015 21:17:01 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jbeich@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-202404-13-0oODxFm54v@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-202404-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-202404-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2015 21:17:01 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202404

--- Comment #2 from Jan Beich <jbeich@FreeBSD.org> ---
mplayer2 port inherited a lot of cruft from mplayer port. Try using |svn blame|
on the parent. For example, CODEC_* was removed in ports r393396 but != usage
predated bug 79823 thus the whole WIN32 conditional could be optimized into

  OPTIONS_DEFINE_i386+=   WIN32

  # Depend on RESTRICTED package when built manually
  .if !defined(PACKAGE_BUILDING)
  OPTIONS_DEFAULT_i386+=  WIN32
  .endif

  WIN32_DESC=             Win32 codec pack support
  WIN32_RUN_DEPENDS=      win32-codecs>0:${PORTSDIR}/multimedia/win32-codecs
  WIN32_CONFIGURE_ON=     --codecsdir=${LOCALBASE}/lib/win32
  WIN32_CONFIGURE_OFF=    --disable-win32dll --disable-qtx


X11 option can be optimized via ports r394573.

-- 
You are receiving this mail because:
You are the assignee for the bug.