From owner-p4-projects@FreeBSD.ORG  Thu Feb 14 15:49:19 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AA81916A592; Thu, 14 Feb 2008 15:49:18 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69F3C16A502
	for <perforce@freebsd.org>; Thu, 14 Feb 2008 15:49:18 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 1075813C474
	for <perforce@freebsd.org>; Thu, 14 Feb 2008 15:49:08 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 924711A4D9E;
	Thu, 14 Feb 2008 07:49:07 -0800 (PST)
From: John Baldwin <jhb@freebsd.org>
To: Kip Macy <kmacy@freebsd.org>
Date: Thu, 14 Feb 2008 10:32:33 -0500
User-Agent: KMail/1.9.7
References: <200802080420.m184Kvmf077416@repoman.freebsd.org>
In-Reply-To: <200802080420.m184Kvmf077416@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802141032.33861.jhb@freebsd.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 135010 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2008 15:49:19 -0000

On Thursday 07 February 2008 11:20:57 pm Kip Macy wrote:
> http://perforce.freebsd.org/chv.cgi?CH=135010
> 
> Change 135010 by kmacy@kmacy:storage:toehead on 2008/02/08 04:20:17
> 
> 	add opt_global.h to dependencies
> 
> Affected files ...
> 
> .. //depot/projects/toehead/sys/modules/cxgb/tom/Makefile#3 edit
> 
> Differences ...
> 
> ==== //depot/projects/toehead/sys/modules/cxgb/tom/Makefile#3 (text+ko) ====
> 
> @@ -5,7 +5,8 @@
>  KMOD=	tom
>  SRCS=   cxgb_tom.c cxgb_cpl_io.c cxgb_listen.c cxgb_tom_sysctl.c cxgb_cpl_socket.c
>  SRCS+=  cxgb_ddp.c cxgb_vm.c
> -SRCS+=	opt_compat.h opt_inet.h opt_inet6.h opt_ipsec.h opt_mac.h opt_tcpdebug.h opt_ddb.h
> +SRCS+=	opt_compat.h opt_inet.h opt_inet6.h opt_ipsec.h opt_mac.h
> +SRCS+=  opt_tcpdebug.h opt_ddb.h opt_global.h
>  SRCS+=	device_if.h bus_if.h pci_if.h
>  
>  #CFLAGS+= -DDEBUG_PRINT -DDEBUG
> 

That's kind of odd.  Do you have an explicit #include "opt_global.h" somewhere?

-- 
John Baldwin