From owner-cvs-src@FreeBSD.ORG Thu Apr 15 11:44:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5496316A4CF for ; Thu, 15 Apr 2004 11:44:58 -0700 (PDT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id E7F5F43D55 for ; Thu, 15 Apr 2004 11:44:53 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 20883 invoked from network); 15 Apr 2004 18:44:53 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 15 Apr 2004 18:44:53 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i3FIigl6002029; Thu, 15 Apr 2004 14:44:49 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Mike Silbersack Date: Thu, 15 Apr 2004 14:35:25 -0400 User-Agent: KMail/1.6 References: <200404120913.i3C9DOkd075451@repoman.freebsd.org> <200404132258.31816.jhb@FreeBSD.org> <20040415023200.D10243@odysseus.silby.com> In-Reply-To: <20040415023200.D10243@odysseus.silby.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200404151435.25450.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Mark Murray cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/random randomdev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2004 18:44:58 -0000 On Thursday 15 April 2004 03:32 am, Mike Silbersack wrote: > On Tue, 13 Apr 2004, John Baldwin wrote: > > You should drop the lock before uiomove(). If the uio can possibly > > reference user memory, then uiomove() will do a copyout() which can fault > > and thus sleep if the page is in swap. > > > > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > > I'm going to have a similar problem in sendfile when I try to de-giantify > it, and I'm sure read / write will have issues as well... will WITNESS > catch this potential problem? Not currently. One could add a WITNESS_WARN() check to uiomove() fairly easily though to force witness to catch this. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org