From owner-svn-src-all@freebsd.org Tue Apr 24 18:28:22 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDBA2FAEE91; Tue, 24 Apr 2018 18:28:21 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 83EA46D2B8; Tue, 24 Apr 2018 18:28:21 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f179.google.com with SMTP id d26-v6so23858667ioc.2; Tue, 24 Apr 2018 11:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=FCqNQQp3avmniwZtJRI+1VOj2A2tQJ70Vv3PIl4IriI=; b=RV92pxD3LeFXudpiswXk4nGepKr1I7lV0r8lb+TjfP0+qdbjeC+5SaWXuOsWSiQV/t 96EEJ5WJEyjKUa6Pu49Lfj6Zau3/HMMLJLJCuhUUqiUwUPvnmwwQk7OUR/haXXWPAX7A zNji/ofp2bZyKF8nkhXhHmzur9CiRHsPxthNiG1ndGw5V7+1qivamnClQNfXyEQoGuXz LiGURnVTpUssi/2Pat3StJMgwkifG21FaMPdmu24BD9BSA8dvc6Ko15x01oYWOmv6zyU sXihZBUJiRvraSd46jYDMDfPGxd287smbmbpXp7Toepr1xoJ4AI4m3qwtuAKIZHMXL/o tZtg== X-Gm-Message-State: ALQs6tA7mI+tjHhN5NUcr9rKR0QHuDIpy0P2ipcf6S5RkgHkVDlUIhst nTeGLNF88ObdII9MxQsgD1LJ18c1 X-Google-Smtp-Source: AIpwx4+GcJtXo2GTfw9b9o28n0GB+dli1xRKmVUDLnWbwr2e4qgWlZt18mRbv7eInu4zm5PimJg6UA== X-Received: by 2002:a6b:6f0a:: with SMTP id k10-v6mr6117078ioc.93.1524594494578; Tue, 24 Apr 2018 11:28:14 -0700 (PDT) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com. [209.85.223.178]) by smtp.gmail.com with ESMTPSA id t65-v6sm7172152iof.88.2018.04.24.11.28.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 11:28:14 -0700 (PDT) Received: by mail-io0-f178.google.com with SMTP id f3-v6so23830520iob.13; Tue, 24 Apr 2018 11:28:14 -0700 (PDT) X-Received: by 2002:a6b:3f05:: with SMTP id m5-v6mr26638281ioa.220.1524594494121; Tue, 24 Apr 2018 11:28:14 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:224d:0:0:0:0:0 with HTTP; Tue, 24 Apr 2018 11:28:13 -0700 (PDT) In-Reply-To: <744fa604-c33c-5f58-6443-4c485136b4fb@cs.duke.edu> References: <201804211705.w3LH50Dk056339@repo.freebsd.org> <20180423180024.GC84833@raichu> <1739228.8pyHcvzasL@ralph.baldwin.cx> <744fa604-c33c-5f58-6443-4c485136b4fb@cs.duke.edu> From: Conrad Meyer Date: Tue, 24 Apr 2018 11:28:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332860 - head/sys/kern To: Andrew Gallatin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 18:28:22 -0000 Next time you encounter something like this, please file a bug. There's no reason to have broken kernel dumps for a year. It took 10 minutes to diagnose. On Tue, Apr 24, 2018 at 10:38 AM, Andrew Gallatin wrote: > On 04/24/18 13:24, Jonathan T. Looney wrote: >> >> On Mon, Apr 23, 2018 at 6:04 PM, John Baldwin > > wrote: >> > >> > I think this is actually a key question. In my experience to date I >> have not >> > encountered a large number of post-panic assertion failures. Given >> that >> > we already break all locks and disable assertions for locks I'd be >> curious >> > which assertions are actually failing. My inclination given my >> experiences >> > to date would be to explicitly ignore those as we do for locking if it >> is >> > constrained set rather than blacklisting all of them. However, I would >> be >> > most interested in seeing some examples of assertions that are failing. >> >> The latest example (the one that prompted me to finally commit this) is in >> lockmgr_sunlock_try(): 'panic: Assertion (*xp & ~LK_EXCLUSIVE_SPINNERS) == >> LK_SHARERS_LOCK(1) failed at /usr/src/sys/kern/kern_lock.c:541' >> >> I don't see any obvious recent changes that would have caused this, so >> this is probably a case where a change to another file suddenly made us trip >> over this assert. > > > FWIW, that assertion has prevented me from getting a dump from an > INVARIANTS kernel for at least a year. > > Drew