From owner-cvs-all  Tue Nov 27 12:21:45 2001
Delivered-To: cvs-all@freebsd.org
Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15])
	by hub.freebsd.org (Postfix) with ESMTP
	id ACA1237B405; Tue, 27 Nov 2001 12:21:31 -0800 (PST)
Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5])
	by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id WAA75072;
	Tue, 27 Nov 2001 22:21:26 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Received: from notebook.vega.com (h52.228.dialup.iptcom.net [212.9.228.52])
	by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id WAA02046;
	Tue, 27 Nov 2001 22:21:18 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-Id: <200111272021.WAA02046@ipcard.iptcom.net>
To: silby@silby.com, des@ofug.org
Cc: brian@freebsd-services.com, rwatson@FreeBSD.org,
	gshapiro@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
From: Maxim Sobolev <sobomax@FreeBSD.org>
Subject: Re: cvs commit: src/etc security
X-Mailer: Pygmy (v0.5.13)
Date: Tue, 27 Nov 2001 22:20:54 EET
In-Reply-To: <20011127115346.R39566-100000@achilles.silby.com>
Content-type: text/plain
Content-Transfer-Encoding: quoted-printable
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, 27 Nov 2001 11:55:53 -0600 (CST), Mike Silbersack wrote:
> =

> On 27 Nov 2001, Dag-Erling Smorgrav wrote:
> =

> > Mike Silbersack <silby@silby.com> writes:
> > > +=09=09=09    mail -s '$host security check output' $daily_status_sec=
urity_output;;
> >
> > Variables aren't expanded inside single-quoted strings.  Use double
> > quotes.
> >
> > DES
> > --
> > Dag-Erling Smorgrav - des@ofug.org
> =

> Yep, that does the trick.  At this rate, I may eventually learn shell
> scripting. :)
> =

> Here's the revised patch, I'll go ahead and commit it in a few hours
> unless there are further problems found.
> =

> Mike "Silby" Silbersack
> =

> --- /usr/src/etc/security=09Tue Nov 27 11:08:21 2001
> +++ /etc/security=09Tue Nov 27 11:13:35 2001
> @@ -58,8 +58,6 @@
>  yesterday=3D`date -v-1d "+%b %e "`
> =

>  host=3D`hostname`
> -[ $sflag =3D FALSE ] && echo "To: root@${host}"
> -[ $sflag =3D FALSE ] && echo "Subject: ${host} security check output"
> =

>  umask 027
> =

> --- /usr/src/etc/periodic/daily/450.status-security=09Wed Jun  6 14:24:44=
 2001
> +++ /etc/periodic/daily/450.status-security=09Tue Nov 27 11:55:00 2001
> @@ -36,8 +36,10 @@
>  =09=09=09    >$daily_status_security_output 2>&1;;
>  =09=09    *)
>  =09=09=09echo "    (output mailed separately)"
> +=09=09=09host=3D`hostname`
> +=09=09=09export host

What purpose this "export" serves?

>  =09=09=09sh /etc/security $args 2>&1 |
> -=09=09=09    sendmail $daily_status_security_output;;
> +=09=09=09    mail -s "$host security check output" $daily_status_securit=
y_output;;

Why not:
+=09mail -s "`hostname` security check output"
?

-Maxim

>  =09=09esac;;
>  =09esac;;
> =

> =

> =

> =


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message