From owner-freebsd-hackers@FreeBSD.ORG Sun Jun 19 09:14:21 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82A73106564A; Sun, 19 Jun 2011 09:14:21 +0000 (UTC) (envelope-from brix@freebsd.org) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id B05D88FC0C; Sun, 19 Jun 2011 09:14:20 +0000 (UTC) Received: from druadan.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTPA id 9B6BB1CC00A; Sun, 19 Jun 2011 11:14:19 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-6--544824696" From: Henrik Brix Andersen In-Reply-To: Date: Sun, 19 Jun 2011 11:14:16 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <379A724C-4458-4E5C-81E9-CF125666E203@FreeBSD.org> To: Chris Rees X-Pgp-Agent: GPGMail 1.3.3 X-Mailer: Apple Mail (2.1084) Cc: hackers@freebsd.org Subject: Re: CONF class of files X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2011 09:14:21 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-6--544824696 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Jun 19, 2011, at 10:50, Chris Rees wrote: > On 19 June 2011 09:15, Henrik Brix Andersen wrote: >>=20 >> On Jun 17, 2011, at 18:40, Chris Rees wrote: >>> Macros are being tested for bsd.port.mk that use a new class of = files, >>> in the same vein as the BINOWN variables I have introduced CONFOWN, >>> CONFGRP, CONFMODE and CONFDIR. >>>=20 >>> Please would someone review and give an opinion on [1]? >>=20 >> Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc? >>=20 >> Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk = where we currently use some form of */etc/* - otherwise we will get a = mismatch if $CONFDIR is changed from the default. >=20 > CONFDIR is for base, not ports, just like most other stuff in that > file. Have a look at the other DIR variables. Gah, I was confused by you initial mail mentioning bsd.port.mk. Rereading the patch, I think it looks good. I'd love to see this go in = before 9.0 as well. Brix --=20 Henrik Brix Andersen --Apple-Mail-6--544824696 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk39vegACgkQv+Q4flTiePig8gCfevlUn7vuz09cqJe5D9qpE2ci msMAnAtdeVUOsjO0sEUMBsM9cghvIzSx =ZY1n -----END PGP SIGNATURE----- --Apple-Mail-6--544824696--