From owner-svn-src-head@freebsd.org Wed Dec 9 20:47:13 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DFEF74AF27C; Wed, 9 Dec 2020 20:47:13 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Crpy86m8Xz3rRQ; Wed, 9 Dec 2020 20:47:12 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 4F02C2601E4; Wed, 9 Dec 2020 21:47:11 +0100 (CET) Subject: Re: svn commit: r368492 - head/sbin/ifconfig From: Hans Petter Selasky To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202012092013.0B9KDCAg083174@repo.freebsd.org> Message-ID: <1d264658-6513-e2a2-062b-1b21296b054f@selasky.org> Date: Wed, 9 Dec 2020 21:46:57 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Crpy86m8Xz3rRQ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-3.30 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[selasky.org]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_ZRD(0.00)[88.99.82.50:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_DBL_DONT_QUERY_IPS(0.00)[88.99.82.50:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2020 20:47:13 -0000 On 12/9/20 9:19 PM, Hans Petter Selasky wrote: > On 12/9/20 9:13 PM, Hans Petter Selasky wrote: >> because the date pointed > > because the data pointed >               ^^ spelling fix Just a heads up: I plan on making this a separate direct-commit to 12-stable tomorrow, because this change depends on, r366917, stacked VLANs, which I have no intention of MFC'ing. The fix for 12-stable looks like this: > Index: sbin/ifconfig/ifclone.c > =================================================================== > --- sbin/ifconfig/ifclone.c (revision 368297) > +++ sbin/ifconfig/ifclone.c (working copy) > @@ -124,6 +124,7 @@ > struct ifreq ifr; > struct clone_defcb *dcp; > clone_callback_func *clone_cb = NULL; > + const char *ifr_name = strchr(name, '.') ? "vlan" : name; > > memset(&ifr, 0, sizeof(ifr)); > (void) strlcpy(ifr.ifr_name, name, sizeof(ifr.ifr_name)); > @@ -131,7 +132,7 @@ > if (clone_cb == NULL) { > /* Try to find a default callback */ > SLIST_FOREACH(dcp, &clone_defcbh, next) { > - if (strncmp(dcp->ifprefix, ifr.ifr_name, > + if (strncmp(dcp->ifprefix, ifr_name, > strlen(dcp->ifprefix)) == 0) { > clone_cb = dcp->clone_cb; > break; --HPS