From owner-cvs-src-old@FreeBSD.ORG  Fri Jun  5 09:17:06 2009
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5F42106564A
	for <cvs-src-old@freebsd.org>; Fri,  5 Jun 2009 09:17:06 +0000 (UTC)
	(envelope-from brian@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id A2C928FC17
	for <cvs-src-old@freebsd.org>; Fri,  5 Jun 2009 09:17:06 +0000 (UTC)
	(envelope-from brian@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n559H6xY064307
	for <cvs-src-old@freebsd.org>; Fri, 5 Jun 2009 09:17:06 GMT
	(envelope-from brian@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n559H6IT064306
	for cvs-src-old@freebsd.org; Fri, 5 Jun 2009 09:17:06 GMT
	(envelope-from brian@repoman.freebsd.org)
Message-Id: <200906050917.n559H6IT064306@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	brian@repoman.freebsd.org using -f
From: Brian Somers <brian@FreeBSD.org>
Date: Fri, 5 Jun 2009 09:16:52 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/kern kern_malloc.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2009 09:17:07 -0000

brian       2009-06-05 09:16:52 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_malloc.c 
  Log:
  SVN rev 193490 on 2009-06-05 09:16:52Z by brian
  
  If we're passed garbage in malloc_init(), panic() rather than expecting
  a KASSERT to handle it.  People are likely to turn off INVARIANTS RSN
  and loading an old module can cause garbage-in here.
  
  I saw the issue with an older nvidia driver (x11/nvidia-driver) loading
  into a new kernel - a crash wasn't seen 'till sysctl_kern_malloc_stats().
  I was lucky that mtp->ks_shortdesc was NULL and not something horrible.
  
  While I'm here, KASSERT that malloc_uninit() isn't passed something that's
  not in kmemstatistics.
  
  MFC after:      3 weeks
  
  Revision  Changes    Path
  1.172     +7 -3      src/sys/kern/kern_malloc.c