From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 18 13:10:02 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DA5C31065672 for ; Wed, 18 Jul 2012 13:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AA41E8FC12 for ; Wed, 18 Jul 2012 13:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6IDA1HX039701 for ; Wed, 18 Jul 2012 13:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6IDA1r5039700; Wed, 18 Jul 2012 13:10:01 GMT (envelope-from gnats) Resent-Date: Wed, 18 Jul 2012 13:10:01 GMT Resent-Message-Id: <201207181310.q6IDA1r5039700@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alberto Villa Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F01F41065678 for ; Wed, 18 Jul 2012 13:06:53 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id DAF598FC18 for ; Wed, 18 Jul 2012 13:06:53 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6ID6rYl064897 for ; Wed, 18 Jul 2012 13:06:53 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q6ID6r2a064896; Wed, 18 Jul 2012 13:06:53 GMT (envelope-from nobody) Message-Id: <201207181306.q6ID6r2a064896@red.freebsd.org> Date: Wed, 18 Jul 2012 13:06:53 GMT From: Alberto Villa To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/169970: [patch] /usr/ports/Makefile: get feedback from SVN and sync with /usr/src/Makefile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2012 13:10:02 -0000 >Number: 169970 >Category: ports >Synopsis: [patch] /usr/ports/Makefile: get feedback from SVN and sync with /usr/src/Makefile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jul 18 13:10:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Alberto Villa >Release: >Organization: >Environment: >Description: Currently, when running `make update` in /usr/ports with a Subversion repository, there is no output from Subversion, and it looks like nothing is happening. >How-To-Repeat: >Fix: The attached patch removes the "-q" from the `svn` command line, which makes it behave like in /usr/src. While here, I also replaced an "else if" with an "elif", and synced CVS and Subversion update messages with the ones in /usr/src. beat@ suggested to test the changes with an exp-run. Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 301095) +++ Makefile (working copy) @@ -168,15 +168,14 @@ @${SUP} ${SUPFLAGS} ${PORTSSUPFILE} .elif defined(CVS_UPDATE) @echo "--------------------------------------------------------------" - @echo ">>> Updating ${.CURDIR} from cvs repository" ${CVSROOT} + @echo ">>> Updating ${.CURDIR} from CVS repository" ${CVSROOT} @echo "--------------------------------------------------------------" cd ${.CURDIR}; ${CVS} -R -q update -A -P -d -I! -.else -.if exists(${.CURDIR}/.svn) +.elif exists(${.CURDIR}/.svn) @echo "--------------------------------------------------------------" - @echo ">>> Updating ${.CURDIR} from svn repository" + @echo ">>> Updating ${.CURDIR} using Subversion" @echo "--------------------------------------------------------------" - cd ${.CURDIR}; ${SVN} -q update + cd ${.CURDIR}; ${SVN} update .else @echo "--------------------------------------------------------------" @echo ">>> Running ${PORTSNAP}" @@ -193,4 +192,3 @@ .endif .endif .endif -.endif >Release-Note: >Audit-Trail: >Unformatted: