From owner-svn-src-all@freebsd.org Tue Jan 29 16:56:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB2CE14C3A3D; Tue, 29 Jan 2019 16:56:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 450C38F39D; Tue, 29 Jan 2019 16:56:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x643.google.com with SMTP id t13so9579946ply.13; Tue, 29 Jan 2019 08:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+vrjYVxwx9y0Cghknta1Susa+aaACase9rFL9irXzlY=; b=Iu0T1xNhe/ah/8NyFAi8KjC4NmGl8/BqrtG6/xW4GZhEmHFk8cRwYQh812zU8yWN7K i7h0avj6ChLf92k4nCYgaXh/2y2rfsvfG4Vc0hvrGoc4BRhPMOxJ0b2iVdXTOzCkjTXG /Z4l76Q59i7+ZqvV20IDkMD/cShlGS96Zt0yMH0CJ5UThRD7lDOolmnpWmapqsA24nCW ptJ7j/lisE9DgXbf35AXOzJFAau1p/bPG060XPR2uNTSR47vXk3iJ4E3vGbwmO1e0MaZ +hcoJRIKBDTIEs5EIwVZKnn4/VqzAAMVJxTjzZewicXNrGST+m4ytJ//YbnAVv79rgB9 6WzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+vrjYVxwx9y0Cghknta1Susa+aaACase9rFL9irXzlY=; b=OgfEiejerJT+Vba0q0bNcYGWMGp0hxR+xyyCJvG2xB/CGQjw1jeQQd8LCZZd66jp29 3QhDFXGISKCfecUz6ls3bpl9s9qNlRVgUiJK7FJF+/5tPB5bO/TdY0N4KD/5dRR4BKcV 7FHQ4s9E/3RcD6QDFV4Iq/9qWmg12qpBq6kJF0DHqifp1YtoSyZtvxRXTKNbZ15o6Z9/ a9KqrNXbT5GgH+25z/4xeI96wNGsW2ioxYehjkRyW6T+34mxGYBSCK1/NRfDsYFcgdtP 4LtkmS5AhkJaG1nxLWi1NCfor67lkitmr7+9d17OUJgtuDWLe67QOGWDOtTfb3luWuqd yHqQ== X-Gm-Message-State: AJcUuke0s2tD3Tm76YM8N+RpDTIVFqP71YYRBZ6awcokjYlaUo09K6Md zVQzO0wuNQ/Fe2ZaUGXRMCRyUpat X-Google-Smtp-Source: ALg8bN59OvKTkl+CQLnuZD/P46Y+5mN6Ralau4aYP4BS14Tx+5kHmQpU+W2ZNn/NvEtvPnOrEZzHDQ== X-Received: by 2002:a17:902:29a7:: with SMTP id h36mr27073375plb.244.1548780995042; Tue, 29 Jan 2019 08:56:35 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n21sm51923891pfg.84.2019.01.29.08.56.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 08:56:34 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r343543 - head/sbin/bectl/tests From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: <5687EE07-74FB-4233-B51D-C8948641E8CB@gmail.com> Date: Tue, 29 Jan 2019 08:56:33 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <75B5E02D-7BE6-4D6F-BF7A-241E7CF16A5E@gmail.com> References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> <5687EE07-74FB-4233-B51D-C8948641E8CB@gmail.com> To: Kyle Evans X-Rspamd-Queue-Id: 450C38F39D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 16:56:37 -0000 > On Jan 29, 2019, at 08:55, Enji Cooper wrote: >=20 >=20 >>> On Jan 29, 2019, at 08:39, Kyle Evans wrote: >>>=20 >>> On Tue, Jan 29, 2019 at 10:32 AM Enji Cooper wro= te: >>>=20 >>>=20 >>>>> On Jan 28, 2019, at 20:10, Kyle Evans wrote: >>>>>=20 >>>>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrote= : >>>>>=20 >>>>> Author: kevans >>>>> Date: Tue Jan 29 04:08:49 2019 >>>>> New Revision: 343543 >>>>> URL: https://svnweb.freebsd.org/changeset/base/343543 >>>>>=20 >>>>> Log: >>>>> bectl(8) test: Force destroy the zpool in cleanup >>>>>=20 >>>>> This is a wild guess as to why bectl tests failed once upon a time in C= I, >>>>> given no apparent way to see a transcript of cleanup routines with Kyu= a. The >>>>> bectl tests construct a new, clean zpool for every test. The failure >>>>> indicated was because of a mount that was leftover from a previous tes= t, but >>>>> the previous test had succeeded so it's not clear how the mount remain= ed >>>>> leftover unless the `zpool get health ${pool}` had somehow failed. >>>>>=20 >>>>=20 >>>> I left out: the tests are supposed to be constructed to clean up any >>>> mounts that were left over in the course of the test, hence the >>>> assumption that the failure lies in the cleanup. >>>=20 >>> Hi Kyle, >>>=20 >>> The tests use a deterministic zpool name defined locally (not globally),= and will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succe= eds. >>>=20 >>> The tests will work the first time (when the zpool doesn=E2=80=99t exist= ), but I believe they=E2=80=99re actually introducing nondeterminism by acci= dent. I will propose a fix for this. >>>=20 >>> There=E2=80=99s a way to decipher why things failed from /var/log/messag= es and kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t k= now what to look for. Can you please provide a failing ci run? >>>=20 >>=20 >> Hi, >>=20 >> Thanks! Any help is appreciated -- my inquiry to -testing@ in response >> to the weekly report where the failing test [1] was mentioned has been >> met with silence. The failure is consistent in the i386-test job, but >> amd64-test sees nothing of the sort (and neither does my local >> testing). >=20 > Thanks for the reminder to rejoin that list. >=20 >> [1] https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/426/testReport= /sbin.bectl/bectl_test/bectl_mount/ >=20 > It=E2=80=99s pretty obvious from the above run what=E2=80=99s going on fro= m the output. A similarly named zpool (same prefix; suffixed with a 2) is be= ing matched by grep, even though the test sets up one with a suffix in the p= receding steps. *without a suffix. My bad.=