From owner-freebsd-arch Tue Sep 5 11:11:30 2000 Delivered-To: freebsd-arch@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 1FB4837B422 for ; Tue, 5 Sep 2000 11:11:27 -0700 (PDT) Received: (qmail 25345 invoked from network); 5 Sep 2000 18:11:23 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 5 Sep 2000 18:11:23 -0000 Date: Wed, 6 Sep 2000 05:11:20 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Don Lewis Cc: Robert Watson , freebsd-arch@FreeBSD.ORG Subject: Re: Request for review: restructuring of per-uid resource limits In-Reply-To: <200009051258.FAA24311@salsa.gv.tsc.tdk.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 5 Sep 2000, Don Lewis wrote: > My patch has KASSERT checks that look for ui_sbsize or ui_proccnt going > negative, or not being zero when freeing the uidinfo structure. I > could be convinced to make this checks mandatory. I think sanity checks (if any are implemented) should be mandatory in new code. Perhaps there should be several levels of KASSERTs, with at least one level where the sanity checks are not mandatory (like the current default of INVARIANTS not defined). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message