From owner-dev-commits-src-main@freebsd.org Thu Jul 8 02:30:18 2021 Return-Path: <owner-dev-commits-src-main@freebsd.org> Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5CC7660D90; Thu, 8 Jul 2021 02:30:18 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GL0d64rtTz4pK3; Thu, 8 Jul 2021 02:30:18 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: lwhsu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 86F792A1F2; Thu, 8 Jul 2021 02:30:18 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by mail-yb1-f178.google.com with SMTP id r132so6512054yba.5; Wed, 07 Jul 2021 19:30:18 -0700 (PDT) X-Gm-Message-State: AOAM533+uO8B74j4+CbTnXzxmk3ZrYTzjJg+UkP064r3T5gjr9gBtAvV jKYpiv0MV8I6I1LenLMquOMDgGmiqEjqdj4iai8= X-Google-Smtp-Source: ABdhPJz+AjQNesJYGzkL3Bfa5pZ3DSqAQXmLAZmPRsweGd1hhA7bFZ02dE7w++se+gWO4cOW7XKIeOw8K+up8jUX+Hg= X-Received: by 2002:a25:34d1:: with SMTP id b200mr34319167yba.492.1625711417978; Wed, 07 Jul 2021 19:30:17 -0700 (PDT) MIME-Version: 1.0 References: <202107071122.167BMe50059361@gitrepo.freebsd.org> In-Reply-To: <202107071122.167BMe50059361@gitrepo.freebsd.org> From: Li-Wen Hsu <lwhsu@freebsd.org> Date: Thu, 8 Jul 2021 10:30:06 +0800 X-Gmail-Original-Message-ID: <CAKBkRUwjo2jvnMYBYdtcmyxF=-PY68R9Dp4wHYpZEXVKuz54tg@mail.gmail.com> Message-ID: <CAKBkRUwjo2jvnMYBYdtcmyxF=-PY68R9Dp4wHYpZEXVKuz54tg@mail.gmail.com> Subject: Re: git: d7955cc0ffdf - main - tcp: HPTS performance enhancements To: Randall Stewart <rrs@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/> List-Post: <mailto:dev-commits-src-main@freebsd.org> List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 08 Jul 2021 02:30:18 -0000 On Wed, Jul 7, 2021 at 7:22 PM Randall Stewart <rrs@freebsd.org> wrote: > > The branch main has been updated by rrs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d7955cc0ffdf9fb58013245a6f181c757574ea0a > > commit d7955cc0ffdf9fb58013245a6f181c757574ea0a > Author: Randall Stewart <rrs@FreeBSD.org> > AuthorDate: 2021-07-06 19:23:22 +0000 > Commit: Randall Stewart <rrs@FreeBSD.org> > CommitDate: 2021-07-07 11:22:35 +0000 > > tcp: HPTS performance enhancements > > HPTS drives both rack and bbr, and yet there have been many complaints > about performance. This bit of work restructures hpts to help reduce CPU > overhead. It does this by now instead of relying on the timer/callout to > drive it instead use user return from a system call as well as lro flushes > to drive hpts. The timer becomes a backstop that dynamically adjusts > based on how "late" we are. > > Reviewed by: tuexen, glebius > Sponsored by: Netflix Inc. > Differential Revision: https://reviews.freebsd.org/D31083 > --- > sys/kern/subr_trap.c | 10 + > sys/netinet/in_pcb.h | 4 +- > sys/netinet/tcp_hpts.c | 1309 +++++++++++++++++++++++++---------------- > sys/netinet/tcp_hpts.h | 99 +++- > sys/netinet/tcp_lro.c | 28 +- > sys/netinet/tcp_lro.h | 10 +- > sys/netinet/tcp_stacks/bbr.c | 6 +- > sys/netinet/tcp_stacks/rack.c | 22 +- > 8 files changed, 931 insertions(+), 557 deletions(-) Hi Randall. I think this breaks 32 bits platforms builds, for example: https://ci.freebsd.org/job/FreeBSD-main-i386-LINT/18214/console https://ci.freebsd.org/job/FreeBSD-main-armv7-LINT/1192/console Can you help check this? Thanks! Best, Li-Wen