From owner-freebsd-current@FreeBSD.ORG Thu Dec 1 01:43:49 2011 Return-Path: Delivered-To: current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 1D0AC1065670; Thu, 1 Dec 2011 01:43:49 +0000 (UTC) Date: Thu, 1 Dec 2011 01:43:49 +0000 From: Alexander Best To: Garrett Cooper Message-ID: <20111201014349.GA61475@freebsd.org> References: <201111291607.26546.jhb@freebsd.org> <20111201002515.GA50028@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: Doug Barton , Warner Losh , current@freebsd.org, Warner Losh Subject: Re: Remove debug echo X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 01:43:49 -0000 On Wed Nov 30 11, Garrett Cooper wrote: > On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best wrote: > > On Tue Nov 29 11, Warner Losh wrote: > >> kill it. > >> > >> Warner > >> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote: > >> > >> > Any objections to this?  It removes a weird line during 'make -s buildworld' > >> > output and I think it was debugging accidentally left in in 213077 by Warner: > >> > > >> > Index: newvers.sh > >> > =================================================================== > >> > --- newvers.sh      (revision 228074) > >> > +++ newvers.sh      (working copy) > >> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do > >> > done > >> > > >> > if [ -n "$svnversion" ] ; then > >> > -   echo "$svnversion" > >> >     svn=`cd ${SYSDIR} && $svnversion` > >> >     case "$svn" in > >> >     [0-9]*) svn=" r${svn}" ;; > > > > also... > > > > when running buildkernel via 'make -s', do we really need all those module > > printfs? i see messages for "cleandir", "obj", "depend" and "all". i think for > > 'make -s', that's pure overkill! > > > > for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 and > > you'll get 2680 lines of output. not really *silent*, is it? ;) > > pmake sucks as far as diagnostic output is concerned when compared > with gmake. I'd rather not have to fish through with -j1 (if I'm lucky > and it's not a race) to determine what directory created the "Error > Code" output. With the printouts discussed here, at least you have a > chance at determining what the issue was. > Maybe it's just me, but I like noisy builds -- otherwise the > amount of time I have to spend root-causing the issue becomes > expensive. ehmmm...a noisy silent flag? i totally agree, if we're talking about 'make' in its default mode, but what's the point of a silent flag, if it produces > 2500 lines of output? nobody uses the -s flag for diagnostics. its purpose is to build a kernel without producing a lot of output and also not fiddling with stdout/stderr to achieve that goal. cheers. alex > Thanks, > -Garrett