From nobody Sun Jul 30 22:50:36 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RDc6J5lS1z4pYHv; Sun, 30 Jul 2023 22:50:44 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RDc6B3r1Rz3wtX; Sun, 30 Jul 2023 22:50:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20221208 header.b=cPozs82V; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::112b as permitted sender) smtp.mailfrom=markjdb@gmail.com; dmarc=none Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-583f837054eso46223257b3.3; Sun, 30 Jul 2023 15:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690757440; x=1691362240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=ZkrUp9DomS0MNBj4FcWKqpW9q5QyL2RgbdtbOcYwrz0=; b=cPozs82VdNWpTgCs+6WT9ps/UKaomooOWWIDR2SiJTfpu6OG2pAghJnQyQWzK9ajkF FQiJnM5FQDUeI3t9jjluHZl4GUVKxqpN8ACaSeO2gHAcN9Erf0fV+9RtpdCyI+YYDBso X1QMuTubp3Y12JBdiMDpLF0kwHaKSKaYctg/1JMZMkpbH2McZH/vAIU/Q8lw9XSpKj4V ogc7B9WGQ7c3HPaPX7KvkSf0s5HLZ2t3/PV1qdfNKV6A4xpFZw3QLZKlmtY7h4vVW+hl KO8O80qawD/Vyptlx/bNtyjlOyUbRWVkMjeTJmDhSkNXSyeXeUCXvIH6kbU17mpFT8ji vY3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690757440; x=1691362240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZkrUp9DomS0MNBj4FcWKqpW9q5QyL2RgbdtbOcYwrz0=; b=NLum+1JAhHyBvjbXZIQlbLyDTr3OfBkNisT/DF4jTzbeJZgZTQYTcz3q1Gb0w1yKWe aKEgJ8k9GSJUmCuLC48E+SIfkMrzBK0FmwDz5urAjHoY7HFS99uvh8xg90I7xMPyyZ5X sh3yKD4qO+VSuKJUxNDCRdaUif7OGpQjMwPkj6FIkFzmWopysS7RV6N5/5xYN0eJoMR4 Eb+dra3JbJlIRDmHneqzat8ZRlVaINHaMw0X3TmfHvZwK2VK3REiYgtnGcX/ao4OQ2kW YPtaKhGLGuCx+QdoZzf/tevH2yGSNaLlZbJh7QAdvWxZQFyPw2eY600ftMlnRCXy7tvy dVsw== X-Gm-Message-State: ABy/qLZX/NUfthxav9TgJe3kOwRHb8mmOPKyyo0jOcb1zVK8zCAHJEfh NqVXo2hj/67oHQXCSa8i4KeaMIBrC90= X-Google-Smtp-Source: APBJJlExZaHvqhDIVhl27XeYHjcv9kQ5quhX9ReXxbqa7BLCyOJewM4KsqgxgOkKDUDDj12o+iHMSg== X-Received: by 2002:a81:5d56:0:b0:583:d9dd:38e1 with SMTP id r83-20020a815d56000000b00583d9dd38e1mr9498912ywb.18.1690757439763; Sun, 30 Jul 2023 15:50:39 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id a15-20020a05620a16cf00b0076c94030a2esm1795961qkn.114.2023.07.30.15.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 15:50:38 -0700 (PDT) Date: Sun, 30 Jul 2023 18:50:36 -0400 From: Mark Johnston To: Jessica Clarke Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 65f28f63a73d - main - tools/build: Create toolchain symlinks for non-absolute compiler/linker Message-ID: References: <202307270412.36R4C2vh097664@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202307270412.36R4C2vh097664@gitrepo.freebsd.org> X-Spamd-Result: default: False [-2.64 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.995]; NEURAL_HAM_LONG(-0.98)[-0.983]; NEURAL_HAM_MEDIUM(-0.96)[-0.964]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20221208]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::112b:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4RDc6B3r1Rz3wtX X-Spamd-Bar: -- On Thu, Jul 27, 2023 at 04:12:02AM +0000, Jessica Clarke wrote: > The branch main has been updated by jrtc27: > > URL: https://cgit.FreeBSD.org/src/commit/?id=65f28f63a73d3371d9d724a2018be6d1ada0d3e0 > > commit 65f28f63a73d3371d9d724a2018be6d1ada0d3e0 > Author: Jessica Clarke > AuthorDate: 2023-07-27 04:10:47 +0000 > Commit: Jessica Clarke > CommitDate: 2023-07-27 04:10:47 +0000 > > tools/build: Create toolchain symlinks for non-absolute compiler/linker > > If any of the toolchain variables are not absolute then we need to > create a symlink in WORLDTMP/legacy/bin in order to make them available > during a BUILD_WITH_STRICT_TMPPATH build. This commit appears to break a 13.0-RELEASE jail's ability to build world from the main branch. Specifically, while building clang during the cross tools stage, lib/Support/BLAKE3/blake3.c can't be compiled because immintrin.h isn't found. The host compiler is clang 11.0.1. Some experimentation shows that this version of clang, when invoked using the absolute path of the symlink in tmp/legacy/usr/bin created as of this commit, does not search /usr/lib/clang/11.0.1 for immintrin.h. It only looks in /usr/include. If I invoke clang using a relative path to the symlink, it finds immintrin.h. Newer versions of LLVM don't have this (buggy?) behaviour, they search their resource directory in either case. Is this a bug in the commit, or does this just mean that I need to upgrade my jail? I'm not sure what guarantees we provide with respect to origin versions of source upgrades.