Date: Mon, 30 Mar 2015 12:10:07 -0400 From: John Baldwin <jhb@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Randall Stewart <rrs@netflix.com> Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys Message-ID: <3218826.nq4nR2EqCz@ralph.baldwin.cx> In-Reply-To: <CACYV=-G28b6RpMq62zCykVtPJeJ17TTHqN3pj7rsM9Q-=nMHyg@mail.gmail.com> References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <4E7E0A0A-5125-4F3A-AC0C-D428A972C954@netflix.com> <CACYV=-G28b6RpMq62zCykVtPJeJ17TTHqN3pj7rsM9Q-=nMHyg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, March 28, 2015 01:48:49 PM Davide Italiano wrote: > On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart <rrs@netflix.com> w= rote: > > Hmm does the KPI include the size of the callout structure (which i= s > > private)? > > >=20 > It's KBI, not KPI. >=20 > > If so I suppose we could change the c_flags/c_iflags to > > ushort =E2=80=A6 > > >=20 > I'm not familiar with your changes enough to suggest/propose a fix. > As I previously mentioned, this looks suspicious KBI-wise to me, and = I > reported to you. The KBI issue makes it much harder to MFC. In particular, even though you could move 'c_iflags' to the end to fix most things (though not callout_pending()), many drivers have 'struct callout foo' inside their= softc, etc. and this would break existing modules. OTOH, the uglier hack of adding locking in callout_deactivate() would preserve the KBI and be safe to merge. --=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3218826.nq4nR2EqCz>