From owner-svn-src-all@FreeBSD.ORG Wed Feb 20 18:42:01 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 859439AC; Wed, 20 Feb 2013 18:42:01 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) by mx1.freebsd.org (Postfix) with ESMTP id 2C0A2ADB; Wed, 20 Feb 2013 18:42:00 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r1KIg0K0062364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Feb 2013 10:42:00 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r1KIg0T9062363; Wed, 20 Feb 2013 10:42:00 -0800 (PST) (envelope-from jmg) Date: Wed, 20 Feb 2013 10:42:00 -0800 From: John-Mark Gurney To: John Baldwin Subject: Re: svn commit: r247012 - in head/contrib/binutils: gas/config opcodes Message-ID: <20130220184200.GN55866@funkthat.com> References: <201302192135.r1JLZH27096984@svn.freebsd.org> <201302200809.23854.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201302200809.23854.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 20 Feb 2013 10:42:00 -0800 (PST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2013 18:42:01 -0000 John Baldwin wrote this message on Wed, Feb 20, 2013 at 08:09 -0500: > On Tuesday, February 19, 2013 4:35:17 pm John-Mark Gurney wrote: > > Author: jmg > > Date: Tue Feb 19 21:35:17 2013 > > New Revision: 247012 > > URL: http://svnweb.freebsd.org/changeset/base/247012 > > > > Log: > > add support for AES and PCLMULQDQ instructions to binutils... > > > > Thanks to Mike Belopuhov for the pointer to the OpenBSD patch, though > > OpenBSD's gcc is very different that it only helped w/ where to modify, > > not how... Thanks to jhb for some early reviews... > > > > Reviewed by: imp, kib > > MFC after: 1 month > > Nice! Sorry I wasn't able to review this in more detail. :( Can you also add > support for these instructions to ddb's disassembler? Considering that ddb doesn't appear to support xmm registers, that'll be a bit of work... even simple instructions such as pxor aren't there yet... So, it'd be more like adding all of the SSE instructions to db than just adding the AES instructions... If I had time, I'd do it, but I don't right now.. Also, I just happen to be looking at the declaration in amd64/amd64/db_disasm.c of: static const char * const db_reg[2][4][16] = { shouldn't we change that to: static const char const db_reg[2][4][16][6] = { That would save a level of indirection, and also all those pointers associated... I estimate that it would save about 1k of space on amd64... it might be a bit less, but at least 512 bytes... Just a thought... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."