From owner-svn-src-all@freebsd.org Mon Jan 15 06:16:22 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56074EA73A8 for ; Mon, 15 Jan 2018 06:16:22 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com [209.85.223.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26E57814B5 for ; Mon, 15 Jan 2018 06:16:21 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-io0-f175.google.com with SMTP id f89so3907736ioj.4 for ; Sun, 14 Jan 2018 22:16:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:cc; bh=oX7DUBtiLYEfkrrXGHWcWDuxqoLrGv0pEEaiBgeuvp8=; b=SppK/qab3F+lIm/CO9c5XM4gr61t9/oXD5Ldfg9AiYCuNq0W0+IrltTDETGBU1NebI exPKcLvxYm+IFm0bDaGgVnf5QPldlI6t/pkA1Y/HfYCmTPYxN1hQPRgJaDYYJz/QREmV 6hPxzgkwjKtzJGyv2IjT3numbenzpw/pDySbMErI7GpvpUbyynzIpNjkDrxWn8AImD6u C036vT2Eirrb/WVTzB9/r7EOnPhrkzwtDOaKks6fVUh+6Y9fdepXSkHqxVQ8bNh2kVVW wbj2yMMLp2L3FRqC5nJpCuhZ76v9k1iyznjM3aHDfRrSSj6bIervWg0vWA3TUM4jiB/r ms1Q== X-Gm-Message-State: AKwxytc60YpFUXlHk8EdXVCwz871BJPuTsAQ5fU0GSOTmAkrjhxTSMm2 iRJkJXFy56/I8V1mnT83IVzNuJbD X-Google-Smtp-Source: ACJfBosd3Gf9SoWswKV6yP5U+bZjdm1lT0u44QZhO+UQlbC0MUW11ghEB7WBcAzH7lz3R2B1EgHEEA== X-Received: by 10.107.136.78 with SMTP id k75mr5861474iod.273.1515996975067; Sun, 14 Jan 2018 22:16:15 -0800 (PST) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com. [209.85.223.175]) by smtp.gmail.com with ESMTPSA id w18sm15642572iod.42.2018.01.14.22.16.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 22:16:14 -0800 (PST) Received: by mail-io0-f175.google.com with SMTP id 25so11948580ioj.9 for ; Sun, 14 Jan 2018 22:16:14 -0800 (PST) X-Received: by 10.107.5.142 with SMTP id 136mt37627249iof.239.1515996974490; Sun, 14 Jan 2018 22:16:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.149.147 with HTTP; Sun, 14 Jan 2018 22:15:54 -0800 (PST) In-Reply-To: <201801150500.w0F50RGV047396@repo.freebsd.org> References: <201801150500.w0F50RGV047396@repo.freebsd.org> From: Kyle Evans Date: Mon, 15 Jan 2018 00:15:54 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327991 - head/stand/fdt Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 06:16:22 -0000 On Sun, Jan 14, 2018 at 11:00 PM, Kyle Evans wrote: > Author: kevans > Date: Mon Jan 15 05:00:26 2018 > New Revision: 327991 > URL: https://svnweb.freebsd.org/changeset/base/327991 > > Log: > stand/fdt: don't send clobbered FDT to the kernel > > If fdt_overlay_apply fails at some stage to apply the overlay to the base, > both the base and overlay may be in an inconsistent state (some fixups > applied, some phandles adjusted, some symbols merged). These can be bad for > a number of reasons, to include user frustration if some fixups applied and > not others. Fail a little safer by making a clean copy of the base FDT for > every overlay that we can simply discard if things go awry. > > This also allows us the luxury of simply discarding overlays if we hit some > kind of memory limit or if they're malformed and extremely large for some > reason. We'll now leave a nice error message indicating that some overlays > could not be applied due to size restrictions and we apply what we can. > > I note that our overlay implementation has some flaws that might still leave > your system in an unbootable state even if an overlay applies correctly; > please exercise caution in using overlays until we can swap it out for > libfdt's implementation. > > Tested on: BananaPi-M3 (armv7) > Tested on: Pine64 (aarch64) > Differential Revision: https://reviews.freebsd.org/D13709 > I seem to have droppped this: MFC after: 1 week