Date: Mon, 15 Jan 2018 00:15:54 -0600 From: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327991 - head/stand/fdt Message-ID: <CACNAnaFLAw9m=hGJT=BcekB0MNT4UmvT1nhup4XyHhGpv5pumw@mail.gmail.com> In-Reply-To: <201801150500.w0F50RGV047396@repo.freebsd.org> References: <201801150500.w0F50RGV047396@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 14, 2018 at 11:00 PM, Kyle Evans <kevans@freebsd.org> wrote: > Author: kevans > Date: Mon Jan 15 05:00:26 2018 > New Revision: 327991 > URL: https://svnweb.freebsd.org/changeset/base/327991 > > Log: > stand/fdt: don't send clobbered FDT to the kernel > > If fdt_overlay_apply fails at some stage to apply the overlay to the base, > both the base and overlay may be in an inconsistent state (some fixups > applied, some phandles adjusted, some symbols merged). These can be bad for > a number of reasons, to include user frustration if some fixups applied and > not others. Fail a little safer by making a clean copy of the base FDT for > every overlay that we can simply discard if things go awry. > > This also allows us the luxury of simply discarding overlays if we hit some > kind of memory limit or if they're malformed and extremely large for some > reason. We'll now leave a nice error message indicating that some overlays > could not be applied due to size restrictions and we apply what we can. > > I note that our overlay implementation has some flaws that might still leave > your system in an unbootable state even if an overlay applies correctly; > please exercise caution in using overlays until we can swap it out for > libfdt's implementation. > > Tested on: BananaPi-M3 (armv7) > Tested on: Pine64 (aarch64) > Differential Revision: https://reviews.freebsd.org/D13709 > I seem to have droppped this: MFC after: 1 week
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFLAw9m=hGJT=BcekB0MNT4UmvT1nhup4XyHhGpv5pumw>