From owner-cvs-src@FreeBSD.ORG  Thu Oct  6 17:36:48 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8F85616A41F;
	Thu,  6 Oct 2005 17:36:48 +0000 (GMT) (envelope-from nate@root.org)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 364E443D45;
	Thu,  6 Oct 2005 17:36:48 +0000 (GMT) (envelope-from nate@root.org)
Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net
	[67.119.74.222])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j96HakSA012543
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Thu, 6 Oct 2005 10:36:47 -0700
Message-ID: <434560A7.2010603@root.org>
Date: Thu, 06 Oct 2005 10:36:39 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Stefan Farfeleder <stefanf@FreeBSD.org>
References: <200510061110.j96BAApc034176@repoman.freebsd.org>
	<20051006132738.GG603@wombat.fafoe.narf.at>
	<20051006144454.GF23662@garage.freebsd.pl>
	<20051006154754.GH603@wombat.fafoe.narf.at>
In-Reply-To: <20051006154754.GH603@wombat.fafoe.narf.at>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h
 src/sys/conf files
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2005 17:36:48 -0000

Stefan Farfeleder wrote:
> On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote:
> 
>>On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote:
>>+> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote:
>>+> > pjd         2005-10-06 11:10:10 UTC
>>+> > 
>>+> >   FreeBSD src repository
>>+> > 
>>+> >   Modified files:
>>+> >     sys/sys              libkern.h 
>>+> >     sys/conf             files 
>>+> >   Added files:
>>+> >     sys/libkern          strtok.c 
>>+> >   Log:
>>+> >   Add strtok() and strtok_r() function to libkern.
>>+> 
>>+> Wouldn't it be better to have strsep() instead?
>>
>>Actually we do have strsep() libkern already...
> 
> 
> Oops.  Can you please change nfs_diskless.c to use strsep()?  I think
> it's a mistake to add non-reentrant functions to libkern.
> 
> Stefan

Agreed.

-- 
Nate