From owner-svn-src-projects@FreeBSD.ORG Thu May 5 16:23:05 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEFD71065688; Thu, 5 May 2011 16:23:04 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 103BE8FC14; Thu, 5 May 2011 16:23:02 +0000 (UTC) Received: by wwc33 with SMTP id 33so2409464wwc.31 for ; Thu, 05 May 2011 09:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=xDGbYDk9u8yr5y/tV9FMqluDo3ugcFZ+YsNiRwSq0sA=; b=Y65MVE+fa3A0AyX/iGNHo569EKeL71wHIdmA4iKaQNXfiIyR4/nhva4TmomR+zMAmX 3b0f7+l4gaPPrTZz4yMEw2pc7l19VSchatqdhHf6naXXG9AB1SJQnjSWFRsK9GMzqiAO FuW8kfCItrhlleGE9EX88v2/gj3x67NQUHwlI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=WyboTtzgh1FeV6gYyvq5aFb+PFn5pMybOp/6kmiD+0b06QgsQXMHg+4EZX/YsDAQtF AsilcAL20rtx6kd+LYW2euP2uxa6vFbrxNd/kXxojnD3FMM36+pwwLyye10l5iw1YiAZ G5B5teRb7z2eoV/v16Ijhcyw/dTtuUerfwp5k= MIME-Version: 1.0 Received: by 10.216.67.199 with SMTP id j49mr6579897wed.59.1304610991536; Thu, 05 May 2011 08:56:31 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.172.196 with HTTP; Thu, 5 May 2011 08:56:31 -0700 (PDT) In-Reply-To: <201105051439.p45EdEgC003770@svn.freebsd.org> References: <201105051439.p45EdEgC003770@svn.freebsd.org> Date: Thu, 5 May 2011 08:56:31 -0700 X-Google-Sender-Auth: LFoSOdFDa6XhmsN7f7uF0Ubj1vc Message-ID: From: mdf@FreeBSD.org To: Attilio Rao Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221499 - in projects/largeSMP: gnu/usr.bin/gdb/kgdb lib/libmemstat sys/amd64/acpica sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/cddl/dev/cyclic/i386 sys/cddl/dev/... X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 16:23:05 -0000 On Thu, May 5, 2011 at 7:39 AM, Attilio Rao wrote: > Author: attilio > Date: Thu May =A05 14:39:14 2011 > New Revision: 221499 > URL: http://svn.freebsd.org/changeset/base/221499 > > Log: > =A0Commit the support for removing cpumask_t and replacing it directly wi= th > =A0cpuset_t objects. I suppose it's a bit of a bikeshed issue, but I found a few of the names a little confusing. I'd prefer: s/CPU_OVERLAP/CPU_INTERSECT s/CPU_NAND/CPU_CLRSET (to mirror CPU_CLR) or CPU_SUBTRACT or CPU_DIFFERENCE Possibly also s/CPU_OR/CPU_SETSET or CPU_UNION. In general I found the naming a bit confusing since it seemed that, though these are declared as a set of cpus (cpuset_t) the operation names aren't set-type operations, like UNION, INTERSECT, DIFFERENCE, etc. It looks like the names have been around for a while, but I suspect they don't see much use until this branch. Thanks, matthew