From owner-freebsd-toolchain@freebsd.org Wed Aug 12 05:44:55 2020 Return-Path: Delivered-To: freebsd-toolchain@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 938583BE96C for ; Wed, 12 Aug 2020 05:44:55 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BRJYz2djwz4T8N for ; Wed, 12 Aug 2020 05:44:55 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 58CF83BE96B; Wed, 12 Aug 2020 05:44:55 +0000 (UTC) Delivered-To: toolchain@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 589263BEBC7 for ; Wed, 12 Aug 2020 05:44:55 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BRJYy4Ctbz4T3p; Wed, 12 Aug 2020 05:44:54 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-lj1-f170.google.com with SMTP id w14so880513ljj.4; Tue, 11 Aug 2020 22:44:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1tYqIrfl/ZQTOg19oEUEfxJfCjZsJ0AY9aZ7A70CoR8=; b=sdAMmq1E/kemg8mGMQxtJ3sk87aGardVfOi6de/oAgRwiFLcoGEt4mWLVmCC2WT95E eLt6pklG2RPovzQMnXwAXmxEvrcOXeFIq7cet9x21DYkNh6J8hhGGaaqghgJxP9Sk8KT NVqibAt2Bj06XG/wpdZKzWfXwZJhQGGINeXwAWLZ17aKKOseqwcr40tpcmKhsQNz9yTl 7Oyhbqm2IBqt0TXxxC4b+fAmkRn677Reb936w43ZgxWGlB8hAoVA7iOrEBiSW+J24qJq Z0WKb4qmWRyPmfPPY6nbsLMeSvAYBN/hf24yqwjuBQTPwSjqAgl8sQddH/UF1VMqY+1u bUfg== X-Gm-Message-State: AOAM533PKEGJpbCcNXc0khBvA9ZFmiX9+CC5sxItEPTjtqKi/Y63Df++ T9vWd0V0hHYKqsaXIkV0Oq1mkEIKBPQ= X-Google-Smtp-Source: ABdhPJwjbkHevnjfpfaSHH0U68JFv4j4kTESmMMRsGeGp0+7frH8YN6CrfIC1/wp6K3ECWJ2FCrP1w== X-Received: by 2002:a2e:8903:: with SMTP id d3mr4444199lji.163.1597211092092; Tue, 11 Aug 2020 22:44:52 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id i19sm217122lfi.14.2020.08.11.22.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2020 22:44:51 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id m22so875058ljj.5; Tue, 11 Aug 2020 22:44:51 -0700 (PDT) X-Received: by 2002:a05:651c:115:: with SMTP id a21mr4138999ljb.315.1597211091271; Tue, 11 Aug 2020 22:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20200807212855.GB2551@kib.kiev.ua> <20200808133000.GC2551@kib.kiev.ua> <20200809143742.430764e7@FreeBSD.org> <20200809154312.GH2551@kib.kiev.ua> <20200811235210.41049ad1@FreeBSD.org> In-Reply-To: From: Gleb Popov Date: Wed, 12 Aug 2020 09:44:25 +0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Undefined reference to __atomic_store_8 To: =?UTF-8?Q?T=C4=B3l_Coosemans?= Cc: Konstantin Belousov , toolchain@freebsd.org X-Rspamd-Queue-Id: 4BRJYy4Ctbz4T3p X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=6yearold@gmail.com X-Spamd-Result: default: False [-1.87 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-0.95)[-0.948]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.04)[-1.040]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.12)[0.116]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.170:from]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.170:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 05:44:55 -0000 On Wed, Aug 12, 2020 at 9:21 AM Gleb Popov wrote: > Indeed, this looks like a culprit! When compiling using first command line > (the long one) I get following warnings: > > /wrkdirs/usr/ports/lang/ghc/work/ghc-8.10.1/libraries/ghc-prim/cbits/atomic.c:369:10: > warning: misaligned atomic operation may incur significant performance > penalty [-Watomic-alignment] > return __atomic_load_n((StgWord64 *) x, __ATOMIC_SEQ_CST); > ^ > /wrkdirs/usr/ports/lang/ghc/work/ghc-8.10.1/libraries/ghc-prim/cbits/atomic.c:417:3: > warning: misaligned atomic operation may incur significant performance > penalty [-Watomic-alignment] > __atomic_store_n((StgWord64 *) x, (StgWord64) val, __ATOMIC_SEQ_CST); > ^ > 2 warnings generated. > > I guess this basically means "I'm emitting a call there". So, what's the > correct fix in this case? > I just noticed that Clang emits these warnings (and the call instruction) only for functions handling StgWord64 type. For the same code with StgWord32, like StgWord hs_atomicread32(StgWord x) { #if HAVE_C11_ATOMICS return __atomic_load_n((StgWord32 *) x, __ATOMIC_SEQ_CST); #else return __sync_add_and_fetch((StgWord32 *) x, 0); #endif } no warning is emitted as well as no call. How does clang infer alignment in these cases? What's so special about StgWord64?