From owner-svn-src-head@FreeBSD.ORG Tue Nov 5 20:42:20 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DE0C2D5E; Tue, 5 Nov 2013 20:42:20 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 423E12557; Tue, 5 Nov 2013 20:42:19 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rA5KgHL1010549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 6 Nov 2013 00:42:17 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rA5KgHed010548; Wed, 6 Nov 2013 00:42:17 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 6 Nov 2013 00:42:17 +0400 From: Gleb Smirnoff To: John Baldwin Subject: Re: svn commit: r257696 - in head: libexec/rbootd share/man/man9 sys/compat/svr4 sys/net sys/sys Message-ID: <20131105204217.GK7577@FreeBSD.org> References: <201311051029.rA5ATmmM017799@svn.freebsd.org> <201311051156.09819.jhb@freebsd.org> <20131105192904.GG7577@FreeBSD.org> <201311051447.52382.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201311051447.52382.jhb@freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Nov 2013 20:42:21 -0000 John, On Tue, Nov 05, 2013 at 02:47:52PM -0500, John Baldwin wrote: J> On Tuesday, November 05, 2013 2:29:04 pm Gleb Smirnoff wrote: J> > On Tue, Nov 05, 2013 at 11:56:09AM -0500, John Baldwin wrote: J> > J> On Tuesday, November 05, 2013 5:29:48 am Gleb Smirnoff wrote: J> > J> > Author: glebius J> > J> > Date: Tue Nov 5 10:29:47 2013 J> > J> > New Revision: 257696 J> > J> > URL: http://svnweb.freebsd.org/changeset/base/257696 J> > J> > J> > J> > Log: J> > J> > Drop support for historic ioctls and also undefine them, so that code J> > J> > that checks their presence via ifdef, won't use them. J> > J> J> > J> Most of these are COMPAT_43, but one appears to be a 9.x ioctl? If that's the J> > J> case it's implementation should probably stick around under appropriate J> > J> COMPAT_FREEBSD macros. It looks like it goes all the way back to 4.4BSD, J> > J> so at least COMPAT_FREEBSD4 and later should define the implementation to J> > J> preserve ABI compat for old binaries. J> > J> > Why should we support such broken configurations as running new kernel and J> > ancient core base system utilities? The efforts to keep this are much more J> > expensive, then yields. J> J> Is this ioctl only ever used by ifconfig and not suitable for public consumption? J> If so, then I think removing it is fine. However, it's not clear that this is J> the case from the commit, and it's good to make sure it is really the case. J> J> It might be nice to hide ioctls we think are internal under some #ifdef that tools J> like ifconfig #define to expose them so we are more explicit about which ioctls J> are purely internal, etc. Well, it isn't hidden and actually some applications as zebra/quagga can use it. On previous hacking session at this area, 2 years ago, I noticed that zebra/quagga do use SIOCAIFADDR and it actually does better at filling sockaddrs than our ifconfig :) I am pretty sure that no closed source, but available to wide public, application that configures addresses in FreeBSD kernel exist. In case of open source applications, like zebra/quagga, supporting one major release behind should be enough. -- Totus tuus, Glebius.