From owner-freebsd-bugs@FreeBSD.ORG Tue Feb 7 07:50:05 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3390F16A420 for ; Tue, 7 Feb 2006 07:50:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C031843D53 for ; Tue, 7 Feb 2006 07:50:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k177o3xw068317 for ; Tue, 7 Feb 2006 07:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k177o35G068312; Tue, 7 Feb 2006 07:50:03 GMT (envelope-from gnats) Resent-Date: Tue, 7 Feb 2006 07:50:03 GMT Resent-Message-Id: <200602070750.k177o35G068312@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mihail Balikov Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1EC7416A420 for ; Tue, 7 Feb 2006 07:46:28 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id E04C643D46 for ; Tue, 7 Feb 2006 07:46:27 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k177kR9q043735 for ; Tue, 7 Feb 2006 07:46:27 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k177kRQq043734; Tue, 7 Feb 2006 07:46:27 GMT (envelope-from nobody) Message-Id: <200602070746.k177kRQq043734@www.freebsd.org> Date: Tue, 7 Feb 2006 07:46:27 GMT From: Mihail Balikov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: kern/92948: [patch] em(4) wedges with high traffic X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2006 07:50:05 -0000 >Number: 92948 >Category: kern >Synopsis: [patch] em(4) wedges with high traffic >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Feb 07 07:50:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Mihail Balikov >Release: 7.0-Current >Organization: >Environment: FreeBSD curr 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sat Dec 17 11:36:50 EET 2005 root@curr:/usr/obj/usr/src/sys/joiner i386 >Description: Interface watchdog fires, if tx descriptor ring is not emptied for EM_TX_TIMEOUT seconds. >How-To-Repeat: >Fix: Following comments in em(4) code, watchdog timer should be restarted if we process some descriptors, but current code restarts timer if no descriptors are freed (num_avail == adapter->num_tx_desc_avail) * If there are no pending descriptors, clear the timeout. Otherwise, * if some descriptors have been freed, restart the timeout. It seems to be "typo" bug, this patch fixes problem for me --- em.060207.diff begins here --- --- if_em.c Wed Feb 1 19:42:55 2006 +++ if_em.c.new Tue Feb 7 08:43:03 2006 @@ -2744,7 +2744,7 @@ ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; if (num_avail == adapter->num_tx_desc) ifp->if_timer = 0; - else if (num_avail == adapter->num_tx_desc_avail) + else if (num_avail != adapter->num_tx_desc_avail) ifp->if_timer = EM_TX_TIMEOUT; } adapter->num_tx_desc_avail = num_avail; --- em.060207.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: