From owner-freebsd-x11@freebsd.org Fri Jan 29 03:39:32 2021 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 174C44FB11C for ; Fri, 29 Jan 2021 03:39:32 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DRjkp3xKbz3mbH; Fri, 29 Jan 2021 03:39:30 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.223] (cpe-24-24-163-126.socal.res.rr.com [24.24.163.126]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 60d34e7a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 29 Jan 2021 03:39:23 +0000 (UTC) Subject: Re: i915 intel_frontbuffer_put panic, patch for review/testing To: Ed Maste , freebsd-x11@freebsd.org References: From: Pete Wright Message-ID: Date: Thu, 28 Jan 2021 19:39:18 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4DRjkp3xKbz3mbH X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [0.70 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[174.136.98.114:from]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; NEURAL_SPAM_SHORT(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[174.136.98.114:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-x11]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2021 03:39:32 -0000 On 1/28/21 5:49 PM, Ed Maste wrote: > For the last few months I have been experiencing occasional panics > from intel_frontbuffer_put(), while running OBS-studio. An excerpt > from the backtrace: > > intel_frontbuffer_put() > intel_user_framebuffer_destroy() > _drm atomic_helper_plane_destroy_state() > drm_atomic_helper_plane_destroy_state() > drm_atomic_state_default_clear() > intel_atomic_state_clear() > __drm_atomic_state_free() > intel_atomic_cleanup_work() > linux_work_fn() > > I found a freedesktop.org bug report for an issue that looked > related[1]. Unfortunately the patch attached there does not apply to > Linux 5.4 corresponding to what we have in drm-kmod[2]. > > I've backported the patch and applied it against the 5.4-lts branch in > the drm-kmod repo, and the issue has not recurred. My patch is in a > pull request at [3], and available as a patch file at [4]. Review > and/or testing is very much appreciated. I would be happy to test on my laptop running 13, is there an easy way to download a branch and have it build using the ports infrastructure?  I believe ports using github for distfiles expect a tag not branch.  i can test out building it locally outside of the ports tree, but wanted to see if i could be lazy first :) -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA