From owner-svn-src-head@FreeBSD.ORG  Thu Sep 10 03:47:29 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA1411065692;
	Thu, 10 Sep 2009 03:47:29 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B22E8FC13;
	Thu, 10 Sep 2009 03:47:29 +0000 (UTC)
Received: (from root@localhost)
	by kientzle.com (8.14.3/8.14.3) id n8A3lSiA013324;
	Wed, 9 Sep 2009 20:47:28 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2])
	by kientzle.com with SMTP id sdgit8xmmpxmeqygrpbdaew6fa;
	Wed, 09 Sep 2009 20:47:28 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4AA876CF.8000903@freebsd.org>
Date: Wed, 09 Sep 2009 20:47:27 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.21) Gecko/20090601 SeaMonkey/1.1.16
MIME-Version: 1.0
To: Andrey Chernov <ache@nagual.pp.ru>, Roman Divacky <rdivacky@freebsd.org>, 
	src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
References: <200909081555.n88FtDwe052523@svn.freebsd.org>
	<20090909132616.GA35808@nagual.pp.ru>
	<4AA7C6B9.1020600@freebsd.org>
	<20090909163937.GB37924@nagual.pp.ru>
In-Reply-To: <20090909163937.GB37924@nagual.pp.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: svn commit: r196981 - head/usr.bin/unzip
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Sep 2009 03:47:29 -0000

Andrey Chernov wrote:
> On Wed, Sep 09, 2009 at 08:16:09AM -0700, Tim Kientzle wrote:
>> Since this is only to support -a (which does end-of-line
>> conversions), I would suggest using a rather different
>> set of heuristics that examines end-of-line sequences
>> and control characters only:
>>    * Any byte value <31 that's not CR or LF: not text
> 
> More carefully - <32, TAB and ^Z (MSDOS EOT) must be 
> allowed too and perhaps ^L.

Yes, but be careful.  Remember that -a processing
is destructive; it's better to err on the side of
marking something binary.

Tim