From owner-svn-src-head@FreeBSD.ORG Sun Sep 4 13:09:20 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1949A106564A; Sun, 4 Sep 2011 13:09:20 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 5A3098FC18; Sun, 4 Sep 2011 13:09:18 +0000 (UTC) Received: by wwi36 with SMTP id 36so4354768wwi.31 for ; Sun, 04 Sep 2011 06:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=54EOdp9jfQYXFaN8ncgEqSPVBp1epaEGlYjY0i4allY=; b=IfNs7bbygiYtHNEjP9fy/xmq+HYcxzhj+pwj2363R3bVzK8KSKfnaHeEfIYfeN/HOi VnyzofM0ws7hrnZAYQBJRas19YRNqq9l3HfhGJ6GAuVAQv4FoXoTH87JM49W0Z39XZPR tqjkDdBZxeIPgxMjMP5H4fG+/77/EjHGkMYsg= MIME-Version: 1.0 Received: by 10.227.72.200 with SMTP id n8mr2926324wbj.19.1315141757835; Sun, 04 Sep 2011 06:09:17 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.227.206.139 with HTTP; Sun, 4 Sep 2011 06:09:17 -0700 (PDT) In-Reply-To: <201109041307.p84D72GY092462@svn.freebsd.org> References: <201109041307.p84D72GY092462@svn.freebsd.org> Date: Sun, 4 Sep 2011 15:09:17 +0200 X-Google-Sender-Auth: NmWxJJfLRms7fZCeVnhH2nxTiBI Message-ID: From: Attilio Rao To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: svn commit: r225372 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2011 13:09:20 -0000 2011/9/4 Attilio Rao : > Author: attilio > Date: Sun Sep =C2=A04 13:07:02 2011 > New Revision: 225372 > URL: http://svn.freebsd.org/changeset/base/225372 > > Log: > =C2=A0Interrupts are disabled/enabled when entering and exiting the KDB c= ontext. > =C2=A0While this is generally good, it brings along a serie of problems, > =C2=A0like clocks going off sync and in presence of SW_WATCHDOG, watchdog= s > =C2=A0firing without a good reason (missed hardclock wdog ticks update). Also please notice that intr enable/disable happens in the wrong way as it is done via the MD (x86 specific likely) interface. This is wrong for 2 reasons: 1) There may be some codepaths leading to explicit preemption 2) It should really use an MI interface The right way to do this should be via spinlock_enter(). Attilio --=20 Peace can only be achieved by understanding - A. Einstein