From owner-freebsd-current@FreeBSD.ORG Mon Jun 1 16:39:02 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 493AB1065677 for ; Mon, 1 Jun 2009 16:39:02 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-fx0-f163.google.com (mail-fx0-f163.google.com [209.85.220.163]) by mx1.freebsd.org (Postfix) with ESMTP id 77BB28FC13 for ; Mon, 1 Jun 2009 16:39:01 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by fxm7 with SMTP id 7so1220194fxm.43 for ; Mon, 01 Jun 2009 09:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=MWyUI61qrHgw9GClRYm5PZ8lCuRWr/mkA4uBxH+CY3g=; b=XsZSIOi5siqWxLLV4BiqXwtZO2pP/RSev+XF1xbnObIRYzdmW6dbI4I09hV+ObsGLS TU0xQbMGdduu0IxjXviPyn8R7aIK7maDVKJySFIHeG9UdZpbOPR9ExDpSKvHOu4KGyD+ yxLM7gWphOJgr5COzipYy5tshhKm/paiv3Fos= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hQuajXNcXdvm/NK4HYHdVPRotO+xQT+uj1izEotH58tHfOLJ/4Kmt/SYWKxhFgMOch yGQJDiAgkbapLSfBrYqX3nty05yXf8vkcBW5rnxfzm+aMeku/Scqo1GXgtRZqMs2zTsm drm+txHnTe1Y+0zNlJd8odtSHCm55jp6H5Zs8= MIME-Version: 1.0 Received: by 10.204.112.11 with SMTP id u11mr5859457bkp.134.1243874340472; Mon, 01 Jun 2009 09:39:00 -0700 (PDT) In-Reply-To: <4A240331.1000803@FreeBSD.org> References: <4A23D5A4.6020009@icyb.net.ua> <4A23F4B8.7000002@freebsd.org> <4A240331.1000803@FreeBSD.org> Date: Mon, 1 Jun 2009 16:39:00 +0000 Message-ID: <3a142e750906010939t710f6abah286c8f23f54747ab@mail.gmail.com> From: "Paul B. Mahol" To: Doug Barton Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Andriy Gapon Subject: Re: fsck_y_enable: use -C X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2009 16:39:02 -0000 On 6/1/09, Doug Barton wrote: > Andriy Gapon wrote: >> on 01/06/2009 16:20 Andriy Gapon said the following: >>> What about the following patch? >>> I believe that the idea behind fsck_y_enable is to try to make unattend= ed >>> systems >>> with rw filesystems as recoverable as possible at the cost of potential >>> damage to >>> the data. The new "-C" option should not interfere with this goal, but >>> should >>> reduce recovery time, because currently fsck -y checks *all* filesystem= s >>> from >>> fstab, even those that are ro or clean: >>> >>> -C Check if the =93clean=94 flag is set in the superblock and skip= file >>> system checks if file system was properly dismounted and marked >>> clean. >>> >> >> One potential issue that I've just thought of is that fsck_msdosfs doesn= 't >> seem to >> support this option (even in a dummy way), so it would be a problem for >> those who >> have msdos filesystems in fstab and also have fsck_y_enable. > > I'm a bit concerned that we keep the current option as it is, but I > would support adding an fsck_y_enable_flags option to allow people to > pass -C if they are sure it will work in their environment. IMHO that solution is much better, considering there is "-t" & "-T" flag. --=20 Paul