From owner-dev-commits-src-all@freebsd.org Wed Dec 30 03:10:15 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 328834D3818; Wed, 30 Dec 2020 03:10:15 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5GVv0kptz4W4H; Wed, 30 Dec 2020 03:10:14 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qt1-f176.google.com with SMTP id z3so10224163qtw.9; Tue, 29 Dec 2020 19:10:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xg8am78M2YOGiEQVPEXH22ENvr1qsE039C11ZTQJa/A=; b=etk7bwhRqwS+7QI4WgHCxCKx676AtgMmm1xd7eg5xM0Rwm2EV7Jb9YjpQ/jOfMasxN RoXkMkXszlhmwAtaIHkO/bmVjKQY0v+CRX1fZEUytJWcSW6TvQjrHVmV/aqOkyct/8HF Jz8QpvsrWBqTyoJfwVHtj1Gi27rGGq1vOGZu4EaIuJmCmGCmf7tusje/l0jw3F5POPVW DRMgpY6HUjAS6G9ilooX4XFDHvaednWjccbcu+Io4q6zGp5YrcYh1YJozfPf1+CB+/ht NEi5hXe8LoGZxDEhb5s6vT3Rj89C96DHhefssHPVFF8Z3AFuYHoG+BPHkipVtSGwdccm zzrg== X-Gm-Message-State: AOAM533PZ89qdAg2iPKuYFcWGqtoELvOqyiWAjZza8m+LS2HFYMxiwWc 2YT2XBFl7Fj4+98nM2Hkcd2LWn+kHyqFSw== X-Google-Smtp-Source: ABdhPJw6hiMWs0tmYmOuzfLaStxV55fwri2H0Cqlst8q8zOebbH23zDmlVLTDW28ts+i9SlxrGvKyA== X-Received: by 2002:ac8:6659:: with SMTP id j25mr52137321qtp.322.1609297813651; Tue, 29 Dec 2020 19:10:13 -0800 (PST) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com. [209.85.219.41]) by smtp.gmail.com with ESMTPSA id u20sm27248963qtb.9.2020.12.29.19.10.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 19:10:13 -0800 (PST) Received: by mail-qv1-f41.google.com with SMTP id bd6so7211999qvb.9; Tue, 29 Dec 2020 19:10:13 -0800 (PST) X-Received: by 2002:ad4:5762:: with SMTP id r2mr55275016qvx.45.1609297813071; Tue, 29 Dec 2020 19:10:13 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Tue, 29 Dec 2020 19:10:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D5GVv0kptz4W4H X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 03:10:15 -0000 On Tue, Dec 29, 2020 at 5:21 PM Kyle Evans wrote: > > On Tue, Dec 29, 2020 at 7:00 PM Ryan Libby wrote: > > > > On Tue, Dec 29, 2020 at 4:53 PM Kyle Evans wrote: > > > > > > On Tue, Dec 29, 2020 at 6:50 PM Kyle Evans wrote: > > > > > > > > On Tue, Dec 29, 2020 at 6:38 PM Ryan Libby wrote: > > > > > > > > > > On Tue, Dec 29, 2020 at 3:32 PM Kyle Evans wrote: > > > > > > > > > > > > Hmm, I hadn't done this because we still have in-tree GCC4.2. Might want to go ahead and skip these tests entirely a level up for 4.2. > > > > > > > > > > > > > > > > Ah, thanks for the reminder. I'll take another look re in-tree gcc. > > > > > Based on the other commits I've MFC'd, I'm pretty sure it's been > > > > > broken for months anyway, but I'll see what I can do if the fixes are > > > > > easy. > > > > > > > > > > > > > This should not be the case, we've been running arm/mips/etc. in CI up > > > > until the git transition. > > > > > > Sorry, arm is irrelevant for this branch- but mips/powerpc/sparc64. > > > > Perhaps only x86 was broken... > > > > How was tftpd/tests not already broken with alignas from r367305 which > > MFC'd r358556? > > > > That is an incredibly good question. The latest build for powerpc > shows that it did in-fact descend into and build libexec/tftpd/tests > > > In any case my plan right now is to try to remember the gcc 4.2 > > voodoo, assess, and fix. Please let me know if you think this needs > > immediate revert before then. > > > > Nah, I wouldn't expend the energy on a revert, tbh. If you don't get > it figured out by tomorrow or so, I'll re-test and smack it. Okay, what's going on is that the tftpd/tests/Makefile was already not building the test for gcc < 4.3, due to lack of __COUNTER__. The use of _Alignas and -std=c11 would require gcc 4.7. If we cared, we would bump the minimum gcc version required accordingly. However, since there's no reason to build with gcc >= 4.3 and < 4.7, I don't think we care and I think the current state of affairs on stable/12 is acceptable. I checked powerpc.powerpc64 with in-tree gcc 4.2.1 and buildworld succeeded. Hopefully ci will be up again soon too. I checked amd64 and it failed due to pkru. I don't think we care to fix that either, but we technically could of course. For amd64 the external toolchain with gcc 6.4 is broken at the moment but will be fixed after a few more MFCs. Thanks for reviewing this MFC!