From owner-freebsd-current@freebsd.org Fri Jun 30 18:53:34 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0882D980B5 for ; Fri, 30 Jun 2017 18:53:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 36E9E78A39; Fri, 30 Jun 2017 18:53:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v5UIrS57005582 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 30 Jun 2017 21:53:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v5UIrS57005582 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v5UIrSkS005581; Fri, 30 Jun 2017 21:53:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 30 Jun 2017 21:53:28 +0300 From: Konstantin Belousov To: Oleg Ginzburg Cc: FreeBSD Current , eugen@freebsd.org, Jilles Tjoelker , emaste@freebsd.org, Eric van Gyzen Subject: Re: column regression after https://svnweb.freebsd.org/base?view=revision&revision=r320472 Message-ID: <20170630185328.GW1935@kib.kiev.ua> References: <1578549.T7vdc21kZj@gizmo.my.domain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578549.T7vdc21kZj@gizmo.my.domain> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 18:53:34 -0000 On Fri, Jun 30, 2017 at 09:34:42PM +0300, Oleg Ginzburg wrote: > Hi, > > This commit https://svnweb.freebsd.org/base?view=revision&revision=r320472 > breaks column(1) (and can affect something else this way ). Try to execute > sample from man r320472: > > ( printf "PERM LINKS OWNER GROUP SIZE MONTH DAY " ; printf "HH:MM/YEAR NAME\n" > ; ls -l | sed 1d ) | column -t > > column: line too long > Indeed, there is a typo. The following fixed the issue for me. diff --git a/lib/libc/stdio/fgetws.c b/lib/libc/stdio/fgetws.c index 83d697ea958..f47fea79934 100644 --- a/lib/libc/stdio/fgetws.c +++ b/lib/libc/stdio/fgetws.c @@ -116,7 +116,7 @@ ok: ret = ws; end: FUNLOCKFILE_CANCELSAFE(); - return (ws); + return (ret); error: ret = NULL;