From owner-svn-src-all@FreeBSD.ORG  Wed Aug  1 00:29:55 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7147C1065781;
	Wed,  1 Aug 2012 00:29:55 +0000 (UTC)
	(envelope-from minimarmot@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 346BC8FC1A;
	Wed,  1 Aug 2012 00:29:55 +0000 (UTC)
Received: by pbbro2 with SMTP id ro2so132540pbb.13
	for <multiple recipients>; Tue, 31 Jul 2012 17:29:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=U6zVgoL8EEpcuoRtCap1KIpuppop2EhOckYs1QkP+3k=;
	b=Re1Ywc7kLXaY3TePPpnD4Q2LrTNpeGC3Ro82PQMt8yFCMZ2L7Dwmio+2jFBCPjizDG
	aNrWRi7Rnx4ziabM7CoT7STCElRPlqTYpblDT927ePtogRZYBOUg5HRFfR4xBN86hSuW
	38SbaUvhBlnwHkhkG38uC2mMlhYJYh6dEBJ3hVMMEp3itqNRlWlrLh3mB3FxCy57ty/6
	llCF9LIKFSxqGK1rmckWu5apUJW8hmDB2U1gp4mm18NUwYDRzLRuDLrziJLWvHZ2J4BH
	3ICPpUo9uu3yhhDfUQHMsGwQ+s8i9gRBz2i8ptuDGIeHqh+zT0aj6QTdfbIrXgmFb52b
	P4gQ==
MIME-Version: 1.0
Received: by 10.68.227.201 with SMTP id sc9mr47103339pbc.163.1343780995026;
	Tue, 31 Jul 2012 17:29:55 -0700 (PDT)
Received: by 10.66.149.131 with HTTP; Tue, 31 Jul 2012 17:29:55 -0700 (PDT)
In-Reply-To: <201208010018.q710I2Uh088989@svn.freebsd.org>
References: <201208010018.q710I2Uh088989@svn.freebsd.org>
Date: Tue, 31 Jul 2012 20:29:55 -0400
Message-ID: <CAK2BMK7ZBGupTX7f74hQCfGT1s4_eyHLSBRSezZc+RU5Dvj3nQ@mail.gmail.com>
From: Ben Kaduk <minimarmot@gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r238962 - head/sys/dev/ath/ath_rate/sample
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 00:29:55 -0000

On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> --- head/sys/dev/ath/ath_rate/sample/sample.c   Tue Jul 31 23:54:15 2012        (r238961)
> +++ head/sys/dev/ath/ath_rate/sample/sample.c   Wed Aug  1 00:18:02 2012        (r238962)
> @@ -504,7 +504,7 @@ ath_rate_findrate(struct ath_softc *sc,
>
>         mrr = sc->sc_mrretry;
>         /* XXX check HT protmode too */
> -       if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT) && !sc->sc_mrrprot)
> +       if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT && !sc->sc_mrrprot))
>                 mrr = 0;
>
>         best_rix = pick_best_rate(an, rt, size_bin, !mrr);

Logical '&&' evaluates left-to-right already, so I do not see that the
current parentheses are needed?

-Ben